Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covers move step by step and can't be stopped while moving #90

Closed
rabesocke opened this issue Jun 27, 2020 · 2 comments · Fixed by #93
Closed

Covers move step by step and can't be stopped while moving #90

rabesocke opened this issue Jun 27, 2020 · 2 comments · Fixed by #93
Labels
bug Something isn't working

Comments

@rabesocke
Copy link

rabesocke commented Jun 27, 2020

Describe the bug
I have two problems with version 1.4. At the moment I switched back to version 1.3.

  • The covers can't be stopped while they are moving. They move all the way down and don't respond to the stop button.
  • By activating a scene with several covers all covers move one by one. The first cover moves and when that one is finished the next cover moves. Until version 1.3 all covers moves all together.

To Reproduce
Steps to reproduce the behavior:

  1. Move a cover and click the stop button - the cover do not respond to that click

or

  1. Create a scene with several covers.
  2. Activate the scene

Expected behavior

  • The cover stops by clicking the stop button while moving
  • All covers should move together (and not one by one)

Screenshots
No screenshot

Environment (please complete the following information):

  • Home Assistant version: 0.111.4
  • Platform: cover

Device: (if your problem is related to a specific device)

  • Model: PositionableRollerShutter
  • Type: io:RollerShutterGenericIOComponent
  • Device details
    no further details

Additional context
No additional context necessary

@rabesocke rabesocke added the bug Something isn't working label Jun 27, 2020
@vlebourl
Copy link
Collaborator

vlebourl commented Jun 27, 2020

thank you for your report. we'll have a look rapidly.
@iMicknl regarding the second issue, I think this is related to the addition of the wait to the apply_action. could an async function allow to keep the wait while sending several commands without waiting for the previous ones to finish?

@vlebourl
Copy link
Collaborator

small comment, it would be preferable to open 2 separate issues. Thanks a lot :)

@vlebourl vlebourl linked a pull request Jun 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants