Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make delayed midnight an opt-in feature #694

Closed
iSoron opened this issue Dec 30, 2020 · 0 comments · Fixed by #739
Closed

Make delayed midnight an opt-in feature #694

iSoron opened this issue Dec 30, 2020 · 0 comments · Fixed by #739
Labels
small-enhancement Small improvements to an existing functionality
Milestone
Loop 2.0

Comments

@iSoron
Copy link
Owner

iSoron commented Dec 30, 2020

Description

Since #621 was merged, Loop now extends all days a few hours past midnight (until 3AM). This is probably unexpected behavior for most users. We should make this an opt-in feature instead.

Implementation

Most of the required code is already implemented. We just have to add this option to the settings screen and call DateUtils.setStartDayOffset with the correct arguments when the application starts (in HabitsApplication.onCreate).

Mockup

Screenshot_1609357696
@iSoron iSoron added the small-enhancement Small improvements to an existing functionality label Dec 30, 2020
@iSoron iSoron added this to the Loop 2.0 milestone Dec 30, 2020
@iSoron iSoron mentioned this issue Dec 30, 2020
Closed
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 22, 2021
@hiqua
Implement the midnight delay option
7389238 
Closes iSoron#694.
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 22, 2021
@hiqua
Implement the midnight delay option
10bf62c 
Closes iSoron#694.
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 25, 2021
@hiqua
Implement the midnight delay option
a263183 
Closes iSoron#694.
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 25, 2021
@hiqua
Implement the midnight delay option
0c0046c 
Closes iSoron#694.
@hiqua hiqua mentioned this issue Jan 26, 2021
Closed
@hiqua hiqua mentioned this issue Jan 27, 2021
Merged
@iSoron iSoron closed this as completed in bb8d4ab Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small-enhancement Small improvements to an existing functionality
Projects
None yet
Milestone
Loop 2.0
Development

Successfully merging a pull request may close this issue.

Implement the midnight delay option (alternative) hiqua/uhabits
1 participant
@iSoron