Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes to specific dates #1103

Merged
merged 16 commits into from
Nov 11, 2021
Merged

Add notes to specific dates #1103

merged 16 commits into from
Nov 11, 2021

Conversation

vbh
Copy link
Contributor

@vbh vbh commented Sep 13, 2021 •
edited
Loading

closes #1074

Subtasks

  • Add a notes column to the Repetitions table.
  • Add a notes field to EntryRecord and Entry
  • Implement the dialog for Yes/No habits
  • Implement the dialog for Numeric habits
  • Show the dialog in ListHabitsActivity
  • Show the dialog in HistoryEditorDialog
  • Make CheckmarkButtonView display the notes indicator
  • Make NumberButtonView display the notes indicator
  • Make HistoryChart display the notes indicator
  • Make HistoryChart react differently to short and long press

Images

image host image host image host image host

@vbh vbh marked this pull request as draft September 13, 2021 15:53
@iSoron
Copy link
Owner

iSoron commented Sep 14, 2021

Thank you for the PR and welcome to the project, @vbh! Please let us know when you think this is ready for review.

@vbh vbh marked this pull request as ready for review September 15, 2021 07:52
@hiqua
Copy link
Collaborator

hiqua commented Sep 19, 2021

@vbh can you double-check that ./build.sh build runs fine locally? You might need to run ./gradlew ktlintFormat or similar.

@hiqua
Copy link
Collaborator

hiqua commented Sep 20, 2021

@vbh and you can check https://github.com/iSoron/uhabits/blob/dev/docs/TEST.md to run the tests.

@iSoron
Copy link
Owner

iSoron commented Sep 23, 2021

Thank you for implementing this, @vbh. I will provide you some feedback soon.

@vbh vbh requested a review from iSoron September 29, 2021 16:01
@iSoron
Copy link
Owner

iSoron commented Oct 1, 2021 •
edited
Loading

Thanks for the changes, @vbh! The code looks very good now. The only thing we are missing to complete this feature, I think, is improving the dialogs. I prepared some mocks below, with some design suggestions. Would you like to try to implement them? Please also feel free to suggest any changes.

Light
Light

@vbh vbh requested a review from iSoron November 5, 2021 14:38
@iSoron
Copy link
Owner

iSoron commented Nov 7, 2021

Thanks @vbh, I am planning to review this shortly.

@iSoron iSoron merged commit ecb8ce1 into iSoron:dev Nov 11, 2021
@iSoron
Copy link
Owner

iSoron commented Nov 11, 2021

Merged into dev with a few minor changes. Thanks a lot for implementing this, @vbh!

@iSoron iSoron mentioned this pull request Nov 11, 2021
Closed
@vbh vbh deleted the feat-1074 branch January 1, 2022 04:37
@iSoron iSoron mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiqua hiqua hiqua left review comments

@iSoron iSoron Awaiting requested review from iSoron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to add notes to specific dates
3 participants
@vbh @iSoron @hiqua