-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: Allow users to create groups of habits #2020
base: dev
Are you sure you want to change the base?
Conversation
No subgroups
This reverts commit ec08b60
@iSoron given that this is quite big already, I'm sure this could use a quick review from you to say whether you'd be fine with the general principle or if you already dislike some of this and the overall direction. |
@dharux thanks a lot for your contribution! I see you're implementing quite a lot of features already; I'd suggest to keep it as simple as possible, to the extent that it makes sense. Just as an example, handling habit groups in widget could definitely come later, as another PR. This would make the review more manageable, and this PR more likely to be accepted IMHO. |
This is such a great PR! It solves a problem I had been facing lately with mixing habits that must have their streaks absolutely never broken with other habits that are more lenient Is it be possible for me to use this before it's merged? edit: managed to compile and install it |
Hey @dharux I found a bug whereby the Habits app crashes when pressing on the "EDIT" button within a habit that's inside a group Current workaround is to remove the habit from the group, edit it, then place it back in the group |
This looks like a great addition to the app! |
Features
Implementation
Will follow soon
To do