You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest that we change the focus policy on GlobeView and PlanarView. Here is a little suggestion list for it :
We could add an optional parameter in View constructor. We could call it autoFocus or hasFocus. It would define whether the view.domElement has the focus when the view is created. I believe it should default to true.
When the view.domElement is clicked, it should gain focus. This is already the case for both GlobeView and PlanarView.
When clicking a GUI element (such as widgets or debug menu), the focus should return to the view.domElement :
either when releasing the click (mouseup) for most of the GUI elements,
or at a time predicted in code for specific elements : for instance, when clicking or hitting enter on a suggestion bellow the search bar.
This would improve the Controls. Indeed, we could capture keyboard events no longer on window but on view.domElement. Therefore, if user have some specific keyboard event management on its webpage, including an iTowns viewer would not break it.
Moreover, it would be the occasion to implement the same focus policy on both PlanarControls and GlobeControls.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I suggest that we change the focus policy on
GlobeView
andPlanarView
. Here is a little suggestion list for it :View
constructor. We could call itautoFocus
orhasFocus
. It would define whether theview.domElement
has the focus when theview
is created. I believe it should default totrue
.view.domElement
is clicked, it should gain focus. This is already the case for bothGlobeView
andPlanarView
.view.domElement
:mouseup
) for most of the GUI elements,This would improve the
Controls
. Indeed, we could capture keyboard events no longer onwindow
but onview.domElement
. Therefore, if user have some specific keyboard event management on its webpage, including an iTowns viewer would not break it.Moreover, it would be the occasion to implement the same focus policy on both
PlanarControls
andGlobeControls
.Beta Was this translation helpful? Give feedback.
All reactions