Unmet peer dependency "prop-type" "classnames"

[VincentLanglet]

Expected Behavior

yarn gives no warning

Current Behavior

yarn gives two unmet peer dependency warning

Steps to Reproduce

yarn add notistack

Context

I have a typescript project. I have no reason to add prop-types in mine.
I think prop-types and classnames should be dependencies and not peerDependencies.

Your Environment

Tech	Version
Notistack	v0.4.2

[oliviertassinari]

@iamhosseindhv What do you think of making classnames a dependency instead of a peer dependency? You can benchmark the other libraries, it's what most maintainers do. If your concern is with the potential bundle duplication, you can make the accepted scope wide.

Alternatively, you can replace the package with clsx. We have replaced classnames usage with clsx in Material-UI v4-alpha.

Related to https://github.com/mui-org/material-ui/pull/14572/files#r257685108

[oliviertassinari]

The React team encourages the usage of prop-type as a dependency.

[VincentLanglet]

@oliviertassinari Thanks, let me buy you a 🍔for your interest !

[oliviertassinari]

@VincentLanglet Il faut essayer Cojean maintenant !

[iamhosseindhv]

Thanks @oliviertassinari and @VincentLanglet. I'll move them both to dependencies. And it'll be published in the next version. CHANGELOG