From 252585b4b2bd59508150e21bb994908a9d78f9b0 Mon Sep 17 00:00:00 2001
From: Kirill Rakhman <kirill.rakhman@gmail.com>
Date: Fri, 10 Sep 2021 11:03:15 +0200
Subject: [PATCH] fix: duration plugin when parsing duration from ISO string,
 set missing components to 0 instead of NaN (#1611)

---
 src/plugin/duration/index.js | 2 +-
 test/plugin/duration.test.js | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/plugin/duration/index.js b/src/plugin/duration/index.js
index 4e894647a..10ebb4ca2 100644
--- a/src/plugin/duration/index.js
+++ b/src/plugin/duration/index.js
@@ -84,7 +84,7 @@ class Duration {
       const d = input.match(durationRegex)
       if (d) {
         const properties = d.slice(2)
-        const numberD = properties.map(value => Number(value));
+        const numberD = properties.map(value => (value != null ? Number(value) : 0));
         [
           this.$d.years,
           this.$d.months,
diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js
index cca1a828e..2e804691c 100644
--- a/test/plugin/duration.test.js
+++ b/test/plugin/duration.test.js
@@ -76,6 +76,9 @@ describe('Parse ISO string', () => {
   it('Part ISO string', () => {
     expect(dayjs.duration('PT2777H46M40S').toISOString()).toBe('PT2777H46M40S')
   })
+  it('Formatting missing components', () => {
+    expect(dayjs.duration('PT1H').format('YYYY-MM-DDTHH:mm:ss')).toBe('0000-00-00T01:00:00')
+  })
   it('ISO string with week', () => {
     const d = dayjs.duration('P2M3W4D')
     expect(d.toISOString()).toBe('P2M25D')