Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issues #1044

Closed
tarasbobak opened this issue Sep 11, 2020 · 4 comments
Closed

Localization issues #1044

tarasbobak opened this issue Sep 11, 2020 · 4 comments

Comments

@tarasbobak
Copy link
Contributor

First of all thank you for an awesome library! 😃
This is were I stopped looking for an alternative to momentjs.

While testing dayjs with the locales we use in our project I've found several issues with a library localization.

  1. For Poland (pl), Croatia (hr) and Lithuania (lt) names of month are not in the correct case of the word. Here is a difference between moment and dayjs localization. This are the results of dayjs().format('D MMMM, YYYY');
    image

  2. For Bulgaria (bg), Spain (es), Croatia (hr), Poland (pl), Portugal (pt), Romania (ro), Serbia (sr) there are casing issues - month names are written capitalized while they should be lowercase. Example:
    image

  3. For wekday names dayjs().localeData().weekdays() list there are issues with casing for Bulgaria (bg), Criatia (hr), Poland (pl), Romania (ro) and Serbia (sr). Example:
    image

@iamkun
Copy link
Owner

iamkun commented Sep 11, 2020

Hi, feel free to send us a pr if some locales are not correct.

@tarasbobak
Copy link
Contributor Author

Created PR with fixes.

@iamkun
Copy link
Owner

iamkun commented Sep 14, 2020

Created PR with fixes.

Cool thanks

@iamkun
Copy link
Owner

iamkun commented Oct 27, 2020

I'll close this issue since it's been a while since it's been opened. Feel free to reopen if you have updates on this

@iamkun iamkun closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants