Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hungarian localization #1111

Closed
vassbence opened this issue Oct 4, 2020 · 5 comments · Fixed by #1112
Closed

Improve hungarian localization #1111

vassbence opened this issue Oct 4, 2020 · 5 comments · Fixed by #1112
Labels

Comments

@vassbence
Copy link
Contributor

vassbence commented Oct 4, 2020

Hi!

I would like to improve the hungarian localization! Currently the package does not handle the past relative times at all. The main problem is that in hungarian we don't have a single word to show that a date is in the past, like ago in english. Instead we add letters to each word, for example:

3 years ago => 3 éve where év means year in hungarian
2 hours ago => 2 órája where óra means hour in hungarian
15 minutes ago => 15 perce where perc means minute in hungarian

Does the package support this kind of localization? If not yet I'm happy to dig in the code and add a solution to this if someone can point me in the right direction. Here is how date-fns implements this.

Thanks!

@iamkun
Copy link
Owner

iamkun commented Oct 4, 2020

Maybe this is what you are looking for https://day.js.org/docs/en/customization/relative-time#additional-token-processing

@vassbence
Copy link
Contributor Author

Exactly, thanks, will customize my localization locally and once it's looking good I will create a PR to provide a fix for everybody.

@vassbence
Copy link
Contributor Author

@iamkun would you mind taking a look at #1112? The above problem should be fixed in it already. Thanks!

@iamkun
Copy link
Owner

iamkun commented Oct 21, 2020

Cheers

@iamkun
Copy link
Owner

iamkun commented Oct 23, 2020

🎉 This issue has been resolved in version 1.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants