Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With localeData plugin extended, dayjs misses typescript types on listing name functions, dayjs.weekdays() e.g. #1113

Closed
Mocha-- opened this issue Oct 6, 2020 · 4 comments
Closed

With localeData plugin extended, dayjs misses typescript types on listing name functions, dayjs.weekdays() e.g. #1113

Mocha-- opened this issue Oct 6, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mocha--
Copy link
Contributor

Mocha-- commented Oct 6, 2020

Describe the bug
dayjs does not have function types in Typescript.

Expected behavior
With localeData plugin included, dayjs should have the declaration of functions below.

dayjs.weekdays()
dayjs.weekdaysShort()
dayjs.weekdaysMin()
dayjs.monthsShort()
dayjs.months()

Information

  • Day.js Version 1.8.33
  • OS: Mac
  • Browser Chrome 85
  • Time zone: GMT+11:00
@iamkun iamkun added enhancement New feature or request good first issue Good for newcomers labels Oct 6, 2020
@iamkun
Copy link
Owner

iamkun commented Oct 6, 2020

True, would you like pulling request for this?

@Mocha--
Copy link
Contributor Author

Mocha-- commented Oct 6, 2020

cool, happy to do that.

@zarghamkhandev
Copy link

@Mocha-- are you done with this ?

@iamkun
Copy link
Owner

iamkun commented Oct 23, 2020

Fixed in #1116

@iamkun iamkun closed this as completed Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mocha-- @iamkun @zarghamkhandev