You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
With the release of dayJS 1.9.7 we noticed our charts were rendering incorrect data or no data at all. I was able to trace the issue down to dayJS.tz startOf function returning new data between 1.9.6 and 1.9.7 which is a possible side-effect of #1229.
Note: We are attempting to do a conversion from MomentJS -> DayJS so I have included the momentJS result for the same logic.
Upon further inspection of the dayJS object the $h variable seems to have changed between the releases which is causing the issue. I'm not 100% sure if this is intended behavior or not and if there is a correct way to achieve the same result as 1.9.6 in 1.9.7 but I figured I would bring attention to the side-effect in case others had a similar result.
One thing to note is that momentJS for the same logic returns the same result as 1.9.6
Expected behavior
DayJS startOf would output the same result for startOf across minor releases and / or mimic the result of momentJS.
Information
Day.js Version: 1.9.7 vs 1.9.6
OS: Mac OS Mojave
Browser :Google Chrome: Version 87.0.4280.88 (Official Build) (x86_64)
Time zone: US Eastern Standard Time (EST -5:00)
The text was updated successfully, but these errors were encountered:
Describe the bug
With the release of dayJS 1.9.7 we noticed our charts were rendering incorrect data or no data at all. I was able to trace the issue down to dayJS.tz startOf function returning new data between 1.9.6 and 1.9.7 which is a possible side-effect of #1229.
Note: We are attempting to do a conversion from MomentJS -> DayJS so I have included the momentJS result for the same logic.
Upon further inspection of the dayJS object the
$h
variable seems to have changed between the releases which is causing the issue. I'm not 100% sure if this is intended behavior or not and if there is a correct way to achieve the same result as 1.9.6 in 1.9.7 but I figured I would bring attention to the side-effect in case others had a similar result.One thing to note is that momentJS for the same logic returns the same result as 1.9.6
Expected behavior
DayJS startOf would output the same result for startOf across minor releases and / or mimic the result of momentJS.
Information
The text was updated successfully, but these errors were encountered: