fix: Add format options for iso week and weekyear #1309
Merged
+77
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1309 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 175 175
Lines 1697 1699 +2
Branches 387 388 +1
=========================================
+ Hits 1697 1699 +2
Continue to review full report at Codecov.
|
|
This LGTM. Would you like to update the doc here https://github.com/dayjs/dayjs-website? The doc in the readme is no longer maintained anymore. |
iamkun
approved these changes
Jan 5, 2021
iamkun
pushed a commit
that referenced
this pull request
Jan 9, 2021
## [1.10.3](v1.10.2...v1.10.3) (2021-01-09) ### Bug Fixes * fix customParseFormat plugin strict mode parse meridiem bug ([#1321](#1321)) ([e49eeef](e49eeef)) * fix weekYear plugin missing locale bug ([#1319](#1319)) ([344bdc0](344bdc0)), closes [#1304](#1304) * update advancedFormat plugin to add format options for iso week and weekyear ([#1309](#1309)) ([2c54c64](2c54c64)) * update devHelper to add dev warning setting locale before loading ([c5cc893](c5cc893)) * update German [de] locale yearStart ([1858df8](1858df8)), closes [#1264](#1264)
|
🎉 This PR is included in version 1.10.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 16, 2021
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09) ### Bug Fixes * fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef)) * fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304) * update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64)) * update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893)) * update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09) ### Bug Fixes * fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef)) * fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304) * update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64)) * update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893)) * update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.10.3](iamkun/dayjs@v1.10.2...v1.10.3) (2021-01-09) ### Bug Fixes * fix customParseFormat plugin strict mode parse meridiem bug ([#1321](iamkun/dayjs#1321)) ([e49eeef](iamkun/dayjs@e49eeef)) * fix weekYear plugin missing locale bug ([#1319](iamkun/dayjs#1319)) ([344bdc0](iamkun/dayjs@344bdc0)), closes [#1304](iamkun/dayjs#1304) * update advancedFormat plugin to add format options for iso week and weekyear ([#1309](iamkun/dayjs#1309)) ([2c54c64](iamkun/dayjs@2c54c64)) * update devHelper to add dev warning setting locale before loading ([c5cc893](iamkun/dayjs@c5cc893)) * update German [de] locale yearStart ([1858df8](iamkun/dayjs@1858df8)), closes [#1264](iamkun/dayjs#1264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like moment.js - day.js should allow the format function to be compatible with iso weeks. and since isoweeks are a plugin already, we can just call it.