Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customParseFormat: parse a string with underscore delimiter #1349

Merged
merged 1 commit into from
Jan 22, 2021
Merged

customParseFormat: parse a string with underscore delimiter #1349

merged 1 commit into from
Jan 22, 2021

Conversation

sumbad
Copy link
Contributor

@sumbad sumbad commented Jan 21, 2021 •
edited
Loading

This is a small fix to parse a string for MMM month format with underscore delimiters.

Was added support for next custom formats:

dayjs('21_Dec_2021', 'DD_MMM_YYYY').isValid() // true

dayjs('21_Jan_2021_123523', 'DD_MMM_YYYY_hhmmss').isValid() // true

@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #1349 (8b12779) into dev (e93e6b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1349   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines         1737      1737           
  Branches       394       394           
=========================================
  Hits          1737      1737
Impacted Files Coverage Δ
src/plugin/customParseFormat/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93e6b8...8b12779. Read the comment docs.

@iamkun iamkun merged commit 82ef9a3 into iamkun:dev Jan 22, 2021
iamkun pushed a commit that referenced this pull request Jan 22, 2021
@semantic-release-bot
chore(release): 1.10.4 [skip ci]
2ab64ac 
## [1.10.4](v1.10.3...v1.10.4) (2021-01-22)

### Bug Fixes

* Correct handling negative duration ([#1317](#1317)) ([3f5c085](3f5c085))
* Improve `Duration` types ([#1338](#1338)) ([4aca4b1](4aca4b1))
* parse a string for MMM month format with underscore delimiter ([#1349](#1349)) ([82ef9a3](82ef9a3))
* Update Bengali [bn] locale ([#1329](#1329)) ([02d96ec](02d96ec))
* update locale Portuguese [pt] yearStart ([#1345](#1345)) ([5c785d5](5c785d5))
* update Polish [pl] locale yearStart ([#1348](#1348)) ([e93e6b8](e93e6b8))
* Update Slovenian [sl] relativeTime locale ([#1333](#1333)) ([fe5f1d0](fe5f1d0))
@iamkun
Copy link
Owner

iamkun commented Jan 22, 2021

🎉 This PR is included in version 1.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 16, 2021
Merged
Closed
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.4 [skip ci]
6437504 
## [1.10.4](iamkun/dayjs@v1.10.3...v1.10.4) (2021-01-22)

### Bug Fixes

* Correct handling negative duration ([#1317](iamkun/dayjs#1317)) ([3f5c085](iamkun/dayjs@3f5c085))
* Improve `Duration` types ([#1338](iamkun/dayjs#1338)) ([4aca4b1](iamkun/dayjs@4aca4b1))
* parse a string for MMM month format with underscore delimiter ([#1349](iamkun/dayjs#1349)) ([82ef9a3](iamkun/dayjs@82ef9a3))
* Update Bengali [bn] locale ([#1329](iamkun/dayjs#1329)) ([02d96ec](iamkun/dayjs@02d96ec))
* update locale Portuguese [pt] yearStart ([#1345](iamkun/dayjs#1345)) ([5c785d5](iamkun/dayjs@5c785d5))
* update Polish [pl] locale yearStart ([#1348](iamkun/dayjs#1348)) ([e93e6b8](iamkun/dayjs@e93e6b8))
* Update Slovenian [sl] relativeTime locale ([#1333](iamkun/dayjs#1333)) ([fe5f1d0](iamkun/dayjs@fe5f1d0))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.4 [skip ci]
5ab05e9 
## [1.10.4](iamkun/dayjs@v1.10.3...v1.10.4) (2021-01-22)

### Bug Fixes

* Correct handling negative duration ([#1317](iamkun/dayjs#1317)) ([3f5c085](iamkun/dayjs@3f5c085))
* Improve `Duration` types ([#1338](iamkun/dayjs#1338)) ([4aca4b1](iamkun/dayjs@4aca4b1))
* parse a string for MMM month format with underscore delimiter ([#1349](iamkun/dayjs#1349)) ([82ef9a3](iamkun/dayjs@82ef9a3))
* Update Bengali [bn] locale ([#1329](iamkun/dayjs#1329)) ([02d96ec](iamkun/dayjs@02d96ec))
* update locale Portuguese [pt] yearStart ([#1345](iamkun/dayjs#1345)) ([5c785d5](iamkun/dayjs@5c785d5))
* update Polish [pl] locale yearStart ([#1348](iamkun/dayjs#1348)) ([e93e6b8](iamkun/dayjs@e93e6b8))
* Update Slovenian [sl] relativeTime locale ([#1333](iamkun/dayjs#1333)) ([fe5f1d0](iamkun/dayjs@fe5f1d0))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.10.4 [skip ci]
08d581c 
## [1.10.4](iamkun/dayjs@v1.10.3...v1.10.4) (2021-01-22)

### Bug Fixes

* Correct handling negative duration ([#1317](iamkun/dayjs#1317)) ([3f5c085](iamkun/dayjs@3f5c085))
* Improve `Duration` types ([#1338](iamkun/dayjs#1338)) ([4aca4b1](iamkun/dayjs@4aca4b1))
* parse a string for MMM month format with underscore delimiter ([#1349](iamkun/dayjs#1349)) ([82ef9a3](iamkun/dayjs@82ef9a3))
* Update Bengali [bn] locale ([#1329](iamkun/dayjs#1329)) ([02d96ec](iamkun/dayjs@02d96ec))
* update locale Portuguese [pt] yearStart ([#1345](iamkun/dayjs#1345)) ([5c785d5](iamkun/dayjs@5c785d5))
* update Polish [pl] locale yearStart ([#1348](iamkun/dayjs#1348)) ([e93e6b8](iamkun/dayjs@e93e6b8))
* Update Slovenian [sl] relativeTime locale ([#1333](iamkun/dayjs#1333)) ([fe5f1d0](iamkun/dayjs@fe5f1d0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumbad @iamkun