Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typo for utcOffset method from UTC plugin #1603

Closed
NikiO-INO opened this issue Aug 12, 2021 · 1 comment · Fixed by #1604
Closed

Wrong typo for utcOffset method from UTC plugin #1603

NikiO-INO opened this issue Aug 12, 2021 · 1 comment · Fixed by #1604
Labels
released

Comments

@NikiO-INO
Copy link
Contributor

Describe the bug
Current typo for utcOffset method from UTC plugin is wrong. That method could accept and properly use offset parameter as string, here is an example.

dayjs/src/plugin/utc/index.js

Line 83 in e2feb6b

if (typeof input === 'string') {

Expected behavior
utcOffset method should accept offset parameter either as string or number.

Information

  • Day.js Version v1.10.6
  • OS: MacOS v11.2.3
  • Browser Safari v14.0.3
  • Time zone: GMT+03:00 MSK
@NikiO-INO NikiO-INO mentioned this issue Aug 12, 2021
Merged
@iamkun
Copy link
Owner

iamkun commented Sep 10, 2021

🎉 This issue has been resolved in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed utcOffset method typo from UTC plugin NikiO-INO/dayjs
2 participants
@iamkun @NikiO-INO