ar-iq meridiem function implementation is wrong

[akamfoad]

Describe the bug
All Arabic languages has meridiem function implemented incorrectly, the library provides the hours in 24 format and it must be mapped as below:

Hours	English meridiem	Arabic meridiem
0-11	AM	ص
12-23	PM	م

References:

Default Implementation is:

dayjs/src/index.js

Lines 271 to 274 in 5a108ff

	const meridiemFunc = meridiem || ((hour, minute, isLowercase) => {
	const m = (hour < 12 ? 'AM' : 'PM')
	return isLowercase ? m.toLowerCase() : m
	})

Arabic implementation

dayjs/src/locale/ar-dz.js

Line 20 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-iq.js

Line 21 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-kw.js

Line 20 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-ly.js

Line 13 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-ma.js

Line 21 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-sa.js

Line 20 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

dayjs/src/locale/ar-tn.js

Line 21 in 5a108ff

meridiem: hour => (hour > 12 ? 'ص' : 'م'),

So the logic should be

 meridiem: hour => (hour < 12 ? 'ص' : 'م'), 

Current Behaviour

An Example:

import "dayjs/locale/ar-iq"

dayjs().format("h A")      // 2 PM
dayjs().locale("ar-iq").format("h A")      // 2 ص

Expected behavior
Correct localized meridiem string as ص before 12 and م after 12.

An Example:

import "dayjs/locale/ar-iq"

dayjs().format("h A")      // 2 PM
dayjs().locale("ar-iq").format("h A")      // 2 م

Information

• Day.js Version: v1.10.0.7
• OS: Irrelevant
• Browser Irrelevant
• Time zone: Irrelevant

[iamkun]

🎉 This issue has been resolved in version 1.11.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀