Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add OpUnitType to quarterOfYear startOf/endOf types #1865

Merged
merged 1 commit into from
May 6, 2022

Conversation

jbmiles
Copy link
Contributor

@jbmiles jbmiles commented Apr 21, 2022

Fixes a type error I was getting using dayjs with the quarterOfYear plugin.

example

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1865 (de01e49) into dev (8757477) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1865   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2064      2064           
  Branches       537       537           
=========================================
  Hits          2064      2064           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8757477...de01e49. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented May 6, 2022

Thanks

@iamkun iamkun merged commit 400bc3e into iamkun:dev May 6, 2022
iamkun pushed a commit that referenced this pull request May 6, 2022
## [1.11.2](v1.11.1...v1.11.2) (2022-05-06)

### Bug Fixes

* add OpUnitType (week) to quarterOfYear startOf/endOf types ([#1865](#1865)) ([400bc3e](400bc3e))
* Fix type issue with ManipulateType ([#1864](#1864)) ([d033dfc](d033dfc))
* fix UTC plugin .valueOf not taking DST into account  ([#1448](#1448)) ([27d1c50](27d1c50))
@iamkun
Copy link
Owner

iamkun commented May 6, 2022

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mtt87
Copy link

mtt87 commented Jul 3, 2023

👋 Was there a regression with this? I can't really figure out when the code was changed (perhaps there was a force push that rewrote the history?) but seems like this fix is not there anymore.

I'm looking now at dev branch and it doesn't seem to be there anymore
https://github.com/iamkun/dayjs/blob/dev/types/plugin/quarterOfYear.d.ts

isBefore(date?: ConfigType, unit?: QUnitType): boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants