-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add OpUnitType to quarterOfYear startOf/endOf types #1865
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1865 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 181
Lines 2064 2064
Branches 537 537
=========================================
Hits 2064 2064 Continue to review full report at Codecov.
|
Thanks |
## [1.11.2](v1.11.1...v1.11.2) (2022-05-06) ### Bug Fixes * add OpUnitType (week) to quarterOfYear startOf/endOf types ([#1865](#1865)) ([400bc3e](400bc3e)) * Fix type issue with ManipulateType ([#1864](#1864)) ([d033dfc](d033dfc)) * fix UTC plugin .valueOf not taking DST into account ([#1448](#1448)) ([27d1c50](27d1c50))
🎉 This PR is included in version 1.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👋 Was there a regression with this? I can't really figure out when the code was changed (perhaps there was a force push that rewrote the history?) but seems like this fix is not there anymore. I'm looking now at isBefore(date?: ConfigType, unit?: QUnitType): boolean |
## [1.11.2](iamkun/dayjs@v1.11.1...v1.11.2) (2022-05-06) ### Bug Fixes * add OpUnitType (week) to quarterOfYear startOf/endOf types ([#1865](iamkun/dayjs#1865)) ([400bc3e](iamkun/dayjs@400bc3e)) * Fix type issue with ManipulateType ([#1864](iamkun/dayjs#1864)) ([d033dfc](iamkun/dayjs@d033dfc)) * fix UTC plugin .valueOf not taking DST into account ([#1448](iamkun/dayjs#1448)) ([27d1c50](iamkun/dayjs@27d1c50))
Fixes a type error I was getting using dayjs with the quarterOfYear plugin.
example