Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic language is missing meridiem function #2416

Closed
alandio opened this issue Aug 16, 2023 · 0 comments · Fixed by #2418
Closed

Arabic language is missing meridiem function #2416

alandio opened this issue Aug 16, 2023 · 0 comments · Fixed by #2418

Comments

@alandio
Copy link
Contributor

alandio commented Aug 16, 2023

Describe the bug
In all Arabic locales ar-xx there exists a localized meridiem, but only in the basic ar locale this does not exist. For reference here is how it is done in moment.js https://github.com/moment/moment/blob/e96809208c9d1b1bbe22d605e76985770024de42/locale/ar.js#L143-L154

Another issue which is not related to this and might open another issue for it, is that none of the ar-xx locales use Arabic numerals like seen in the figure below. Is this a decision taken by the team?

different in meridiem format for ar and ar-dz locales

Expected behavior
The ar locale should also localize meridiem to show 'م' or 'ص'

Information

  • Day.js Version: v1.11.9
  • OS: Windows 11
  • Browser: chrome 116
  • Time zone: GMT+03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant