Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relativeTime plugin produces non grammatically valid output for POLISH language #782

Closed
it-xtech-dev opened this issue Jan 20, 2020 · 2 comments
Closed

relativeTime plugin produces non grammatically valid output for POLISH language #782

it-xtech-dev opened this issue Jan 20, 2020 · 2 comments

Comments

@it-xtech-dev
Copy link

it-xtech-dev commented Jan 20, 2020 •
edited
Loading

Describe the bug
Relative time output makes no sens in polish language for function .fromNow (and possibly other function in this plugin).

Expected behavior
Expected output has been documented here:
https://codepen.io/xtech-dev/pen/OJPapqa?editors=0010
(output matters, implementation may of course vary)

Information

  • Day.js Version [v.1.8.19]
  • OS: [Windows 10]
  • Browser [e.g. chrome 79.0.3945.88 ]
  • Time zone: [ UTC/GMT +1 hour]

Additional notes
Resonable solution has been already proposed #659 but seems to be rejected.
@it-xtech-dev it-xtech-dev changed the title relativeTime produces non grammatically valid output for POLISH languge relativeTime produces non grammatically valid output for POLISH language Jan 20, 2020
@it-xtech-dev it-xtech-dev changed the title relativeTime produces non grammatically valid output for POLISH language relativeTime plugin produces non grammatically valid output for POLISH language Jan 20, 2020
@iamkun
Copy link
Owner

iamkun commented Jan 22, 2020

fixed in d372475 and will release soon

@iamkun iamkun closed this as completed Jan 22, 2020
@it-xtech-dev
Copy link
Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamkun @it-xtech-dev