-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Arabic relative time #836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ar-tn, ar-sa, ar-ma, etc... are surprisingly following the correct formatting for relative time. This one should too.
Codecov Report
@@ Coverage Diff @@
## dev #836 +/- ##
===================================
Coverage 100% 100%
===================================
Files 158 158
Lines 1189 1189
Branches 240 240
===================================
Hits 1189 1189
Continue to review full report at Codecov.
|
THX |
iamkun
pushed a commit
that referenced
this pull request
Mar 16, 2020
## [1.8.23](v1.8.22...v1.8.23) (2020-03-16) ### Bug Fixes * Add Chinese (zh) locale ([f9b8945](f9b8945)) * Fix IsoWeek plugin typescript definition ([#828](#828)) ([30aab0c](30aab0c)) * Update Arabic (ar) locale relative time ([#836](#836)) ([14044c6](14044c6)) * Update Slovak (sk) locale, Czech (cs) locale ([#833](#833)) ([f0d451f](f0d451f)) * Update Thai (th) locale relativeTime ([#826](#826)) ([63b7c03](63b7c03)), closes [#816](#816)
🎉 This PR is included in version 1.8.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
epszaw
pushed a commit
to epszaw/dayjs
that referenced
this pull request
Apr 7, 2020
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16) ### Bug Fixes * Add Chinese (zh) locale ([f9b8945](iamkun@f9b8945)) * Fix IsoWeek plugin typescript definition ([iamkun#828](iamkun#828)) ([30aab0c](iamkun@30aab0c)) * Update Arabic (ar) locale relative time ([iamkun#836](iamkun#836)) ([14044c6](iamkun@14044c6)) * Update Slovak (sk) locale, Czech (cs) locale ([iamkun#833](iamkun#833)) ([f0d451f](iamkun@f0d451f)) * Update Thai (th) locale relativeTime ([iamkun#826](iamkun#826)) ([63b7c03](iamkun@63b7c03)), closes [iamkun#816](iamkun#816)
This was referenced Apr 8, 2020
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16) ### Bug Fixes * Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945)) * Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c)) * Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6)) * Update Slovak (sk) locale, Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f)) * Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16) ### Bug Fixes * Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945)) * Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c)) * Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6)) * Update Slovak (sk) locale, Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f)) * Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16) ### Bug Fixes * Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945)) * Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c)) * Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6)) * Update Slovak (sk) locale, Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f)) * Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ar-tn, ar-sa, ar-ma, etc... are surprisingly following the correct formatting for relative time. This one should too.