Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback LocalePresetType to string #968

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Rollback LocalePresetType to string #968

merged 2 commits into from
Jul 29, 2020

Conversation

dyoshikawa
Copy link
Contributor

Fixes #964

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #968 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          169       169           
  Lines         1429      1429           
  Branches       305       305           
=========================================
  Hits          1429      1429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73813ab...500c2b8. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jul 25, 2020

If we have to change it in this way, I suggest removing all the preset and leave string alone.

@dyoshikawa dyoshikawa changed the title Fix: Add string to LocalePresetType Rollback LocalePresetType to string Jul 25, 2020
@dyoshikawa
Copy link
Contributor Author

Thanks your comment. I accepted your suggestion.

@iamkun iamkun merged commit b342bd3 into iamkun:dev Jul 29, 2020
iamkun pushed a commit that referenced this pull request Jul 29, 2020
## [1.8.31](v1.8.30...v1.8.31) (2020-07-29)

### Bug Fixes

* Rollback LocalePresetType to string ([#968](#968)) ([b342bd3](b342bd3))
* Update Regex to parse 'YYYY' correctly ([#969](#969)) ([70c1239](70c1239))
@iamkun
Copy link
Owner

iamkun commented Jul 29, 2020

🎉 This PR is included in version 1.8.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

jnoodle added a commit to jnoodle/picker that referenced this pull request Jul 29, 2020
afc163 added a commit to react-component/picker that referenced this pull request Aug 5, 2020
afc163 added a commit to react-component/picker that referenced this pull request Aug 10, 2020
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.31](iamkun/dayjs@v1.8.30...v1.8.31) (2020-07-29)

### Bug Fixes

* Rollback LocalePresetType to string ([#968](iamkun/dayjs#968)) ([b342bd3](iamkun/dayjs@b342bd3))
* Update Regex to parse 'YYYY' correctly ([#969](iamkun/dayjs#969)) ([70c1239](iamkun/dayjs@70c1239))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.31](iamkun/dayjs@v1.8.30...v1.8.31) (2020-07-29)

### Bug Fixes

* Rollback LocalePresetType to string ([#968](iamkun/dayjs#968)) ([b342bd3](iamkun/dayjs@b342bd3))
* Update Regex to parse 'YYYY' correctly ([#969](iamkun/dayjs#969)) ([70c1239](iamkun/dayjs@70c1239))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.8.31](iamkun/dayjs@v1.8.30...v1.8.31) (2020-07-29)

### Bug Fixes

* Rollback LocalePresetType to string ([#968](iamkun/dayjs#968)) ([b342bd3](iamkun/dayjs@b342bd3))
* Update Regex to parse 'YYYY' correctly ([#969](iamkun/dayjs#969)) ([70c1239](iamkun/dayjs@70c1239))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dayjs.locale() throws type error due to type update in v.1.8.30
2 participants