Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added typedefs in esm build #985

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Added typedefs in esm build #985

merged 1 commit into from
Aug 10, 2020

Conversation

stoicsleuth
Copy link
Contributor

Fixes #971

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #985 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #985   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines         1477      1477           
  Branches       311       311           
=========================================
  Hits          1477      1477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18f739...77c70a0. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Aug 6, 2020

If we implement it in this way, there might be a type error while using plugins.

e.g.

import dayjs from 'dayjs/esm/index'
import utc from 'dayjs/esm/plugin/utc'

dayjs.extend(utc)

dayjs.utc // still type error because the TS compiler will search type file in './index.d.ts' not './esm/index.d.ts'

@iamkun iamkun merged commit 50e3b3c into iamkun:dev Aug 10, 2020
@iamkun
Copy link
Owner

iamkun commented Aug 10, 2020

thanks

iamkun pushed a commit that referenced this pull request Aug 10, 2020
@semantic-release-bot
chore(release): 1.8.33 [skip ci]
6e5ffce 
## [1.8.33](v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](#996)) ([f76e3ce](f76e3ce))
* Add typescript type defs in esm build ([#985](#985)) ([50e3b3c](50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](#993)) ([f2e5f32](f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](#994)) ([22f3d49](22f3d49)), closes [#992](#992) [#989](#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](#987)) ([b07182b](b07182b)), closes [#986](#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](#995)) ([747c0fb](747c0fb))
* Update pt-br locale weekStart 0 ([#984](#984)) ([0f881c1](0f881c1))
@iamkun
Copy link
Owner

iamkun commented Aug 10, 2020

🎉 This PR is included in version 1.8.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
7fba66b 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.33 [skip ci]
217a297 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.8.33 [skip ci]
5ca0e53 
## [1.8.33](iamkun/dayjs@v1.8.32...v1.8.33) (2020-08-10)

### Bug Fixes

* Add PluralGetSet plugin for plural getters/setters ([#996](iamkun/dayjs#996)) ([f76e3ce](iamkun/dayjs@f76e3ce))
* Add typescript type defs in esm build ([#985](iamkun/dayjs#985)) ([50e3b3c](iamkun/dayjs@50e3b3c))
* Fix isoWeek Plugin cal bug in UTC mode ([#993](iamkun/dayjs#993)) ([f2e5f32](iamkun/dayjs@f2e5f32))
* Fix Timezone plugin parsing js date, Day.js object, timestamp bug && update type file ([#994](iamkun/dayjs#994)) ([22f3d49](iamkun/dayjs@22f3d49)), closes [#992](iamkun/dayjs#992) [#989](iamkun/dayjs#989)
* Fix Timezone plugin UTCOffset rounding bug ([#987](iamkun/dayjs#987)) ([b07182b](iamkun/dayjs@b07182b)), closes [#986](iamkun/dayjs#986)
* Fix UTC plugin bug while comparing an utc instance to a local one ([#995](iamkun/dayjs#995)) ([747c0fb](iamkun/dayjs@747c0fb))
* Update pt-br locale weekStart 0 ([#984](iamkun/dayjs#984)) ([0f881c1](iamkun/dayjs@0f881c1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include type defs. in esm build
2 participants
@stoicsleuth @iamkun