forked from argoproj/argo-workflows
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Makefile
461 lines (368 loc) · 16.9 KB
/
Makefile
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
OUTPUT_IMAGE_OS ?= linux
OUTPUT_IMAGE_ARCH ?= amd64
BUILD_DATE = $(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
GIT_COMMIT = $(shell git rev-parse HEAD)
GIT_REMOTE = origin
GIT_BRANCH = $(shell git rev-parse --abbrev-ref=loose HEAD | sed 's/heads\///')
GIT_TAG = $(shell git describe --exact-match --tags HEAD 2>/dev/null || git rev-parse --short=8 HEAD 2>/dev/null)
GIT_TREE_STATE = $(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi)
export DOCKER_BUILDKIT = 1
# docker image publishing options
IMAGE_NAMESPACE ?= argoproj
# The rules for what version are, in order of precedence
# 1. If anything passed at the command line (e.g. make release VERSION=...)
# 2. If on master, it must be "latest".
# 3. If on tag, must be tag.
# 4. If on a release branch, the most recent tag that contain the major minor on that branch,
# 5. Otherwise, the branch.
#
VERSION := $(subst /,-,$(GIT_BRANCH))
ifeq ($(GIT_BRANCH),master)
VERSION := latest
endif
ifneq ($(findstring release,$(GIT_BRANCH)),)
# this will be something like "v2.5" or "v3.7"
MAJOR_MINOR := v$(word 2,$(subst -, ,$(GIT_BRANCH)))
# if GIT_TAG is on HEAD, then this will be the same
GIT_LATEST_TAG := $(shell git describe --abbrev=0 --tags)
ifneq ($(findstring $(MAJOR_MINOR),$(GIT_LATEST_TAG)),)
VERSION := $(GIT_LATEST_TAG)
endif
endif
# MANIFESTS_VERSION is the version to be used for files in manifests and should always be latests unles we are releasing
# we assume HEAD means you are on a tag
ifeq ($(GIT_BRANCH),HEAD)
VERSION := $(GIT_TAG)
MANIFESTS_VERSION := $(VERSION)
DEV_IMAGE := false
else
ifeq ($(findstring release,$(GIT_BRANCH)),release)
MANIFESTS_VERSION := $(VERSION)
DEV_IMAGE := false
else
MANIFESTS_VERSION := latest
DEV_IMAGE := true
endif
endif
# perform static compilation
STATIC_BUILD ?= true
CI ?= false
DB ?= postgres
K3D := $(shell if [ "`kubectl config current-context`" = "k3s-default" ]; then echo true; else echo false; fi)
ARGO_TOKEN = $(shell kubectl -n argo get secret -o name | grep argo-server | xargs kubectl -n argo get -o jsonpath='{.data.token}' | base64 --decode)
override LDFLAGS += \
-X github.com/argoproj/argo.version=$(VERSION) \
-X github.com/argoproj/argo.buildDate=${BUILD_DATE} \
-X github.com/argoproj/argo.gitCommit=${GIT_COMMIT} \
-X github.com/argoproj/argo.gitTreeState=${GIT_TREE_STATE}
ifeq ($(STATIC_BUILD), true)
override LDFLAGS += -extldflags "-static"
endif
ifneq ($(GIT_TAG),)
override LDFLAGS += -X github.com/argoproj/argo.gitTag=${GIT_TAG}
endif
ARGOEXEC_PKGS := $(shell echo cmd/argoexec && go list -f '{{ join .Deps "\n" }}' ./cmd/argoexec/ | grep 'argoproj/argo' | cut -c 26-)
CLI_PKGS := $(shell echo cmd/argo && go list -f '{{ join .Deps "\n" }}' ./cmd/argo/ | grep 'argoproj/argo' | cut -c 26-)
CONTROLLER_PKGS := $(shell echo cmd/workflow-controller && go list -f '{{ join .Deps "\n" }}' ./cmd/workflow-controller/ | grep 'argoproj/argo' | cut -c 26-)
MANIFESTS := $(shell find manifests -mindepth 2 -type f)
E2E_MANIFESTS := $(shell find test/e2e/manifests -mindepth 2 -type f)
E2E_EXECUTOR ?= pns
# The sort puts _.primary first in the list. 'env LC_COLLATE=C' makes sure underscore comes first in both Mac and Linux.
SWAGGER_FILES := $(shell find pkg -name '*.swagger.json' | env LC_COLLATE=C sort)
.PHONY: build
build: status clis executor-image controller-image manifests/install.yaml manifests/namespace-install.yaml manifests/quick-start-postgres.yaml manifests/quick-start-mysql.yaml
.PHONY: status
status:
# GIT_TAG=$(GIT_TAG), GIT_BRANCH=$(GIT_BRANCH), GIT_TREE_STATE=$(GIT_TREE_STATE), VERSION=$(VERSION), DEV_IMAGE=$(DEV_IMAGE)
# cli
.PHONY: cli
cli: dist/argo
ui/node_modules: ui/package.json ui/yarn.lock
# Get UI dependencies
ifeq ($(CI),false)
yarn --cwd ui install --frozen-lockfile --ignore-optional --non-interactive
else
mkdir -p ui/node_modules
endif
touch ui/node_modules
ui/dist/app: ui/node_modules ui/src
# Build UI
ifeq ($(CI),false)
yarn --cwd ui build
else
mkdir -p ui/dist/app
echo "Built without static files" > ui/dist/app/index.html
endif
touch ui/dist/app
$(HOME)/go/bin/staticfiles:
# Install the "staticfiles" tool
go get bou.ke/staticfiles
server/static/files.go: $(HOME)/go/bin/staticfiles ui/dist/app
# Pack UI into a Go file.
staticfiles -o server/static/files.go ui/dist/app
dist/argo: server/static/files.go $(CLI_PKGS)
go build -v -i -ldflags '${LDFLAGS}' -o dist/argo ./cmd/argo
dist/argo-linux-amd64: GOARGS = GOOS=linux GOARCH=amd64
dist/argo-darwin-amd64: GOARGS = GOOS=darwin GOARCH=amd64
dist/argo-windows-amd64: GOARGS = GOOS=windows GOARCH=amd64
dist/argo-linux-arm64: GOARGS = GOOS=linux GOARCH=arm64
dist/argo-linux-ppc64le: GOARGS = GOOS=linux GOARCH=ppc64le
dist/argo-linux-s390x: GOARGS = GOOS=linux GOARCH=s390x
dist/argo-%: server/static/files.go $(CLI_PKGS)
CGO_ENABLED=0 $(GOARGS) go build -v -i -ldflags '${LDFLAGS}' -o $@ ./cmd/argo
.PHONY: cli-image
cli-image: dist/cli-image
dist/cli-image: dist/argo-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH)
# Create CLI image
ifeq ($(DEV_IMAGE),true)
cp dist/argo-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH) argo
docker build -t $(IMAGE_NAMESPACE)/argocli:$(VERSION) --target argocli -f Dockerfile.dev --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
rm -f argo
else
docker build -t $(IMAGE_NAMESPACE)/argocli:$(VERSION) --target argocli --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
endif
touch dist/cli-image
ifeq ($(K3D),true)
k3d import-images $(IMAGE_NAMESPACE)/argocli:$(VERSION)
endif
.PHONY: clis
clis: dist/argo-linux-amd64 dist/argo-linux-arm64 dist/argo-linux-ppc64le dist/argo-linux-s390x dist/argo-darwin-amd64 dist/argo-windows-amd64 cli-image
# controller
dist/workflow-controller-linux-amd64: GOARGS = GOOS=linux GOARCH=amd64
dist/workflow-controller-linux-arm64: GOARGS = GOOS=linux GOARCH=arm64
dist/workflow-controller-%: $(CONTROLLER_PKGS)
CGO_ENABLED=0 $(GOARGS) go build -v -i -ldflags '${LDFLAGS}' -o $@ ./cmd/workflow-controller
.PHONY: controller-image
controller-image: dist/controller-image
dist/controller-image: dist/workflow-controller-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH)
# Create controller image
ifeq ($(DEV_IMAGE),true)
cp dist/workflow-controller-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH) workflow-controller
docker build -t $(IMAGE_NAMESPACE)/workflow-controller:$(VERSION) --target workflow-controller -f Dockerfile.dev --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
rm -f workflow-controller
else
docker build -t $(IMAGE_NAMESPACE)/workflow-controller:$(VERSION) --target workflow-controller --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
endif
touch dist/controller-image
ifeq ($(K3D),true)
k3d import-images $(IMAGE_NAMESPACE)/workflow-controller:$(VERSION)
endif
# argoexec
dist/argoexec-linux-amd64: GOARGS = GOOS=linux GOARCH=amd64
dist/argoexec-linux-arm64: GOARGS = GOOS=linux GOARCH=arm64
dist/argoexec-%: $(ARGOEXEC_PKGS)
CGO_ENABLED=0 $(GOARGS) go build -v -i -ldflags '${LDFLAGS}' -o $@ ./cmd/argoexec
.PHONY: executor-image
executor-image: dist/executor-image
dist/executor-image: dist/argoexec-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH)
# Create executor image
ifeq ($(DEV_IMAGE),true)
cp dist/argoexec-$(OUTPUT_IMAGE_OS)-$(OUTPUT_IMAGE_ARCH) argoexec
docker build -t $(IMAGE_NAMESPACE)/argoexec:$(VERSION) --target argoexec -f Dockerfile.dev --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
rm -f argoexec
else
docker build -t $(IMAGE_NAMESPACE)/argoexec:$(VERSION) --target argoexec --build-arg IMAGE_OS=$(OUTPUT_IMAGE_OS) --build-arg IMAGE_ARCH=$(OUTPUT_IMAGE_ARCH) .
endif
touch dist/executor-image
ifeq ($(K3D),true)
k3d import-images $(IMAGE_NAMESPACE)/argoexec:$(VERSION)
endif
# generation
$(HOME)/go/bin/mockery:
go get github.com/vektra/mockery/.../
.PHONY: codegen
codegen: $(HOME)/go/bin/mockery
# Generate code
# We need the folder for compatibility
go mod vendor
./hack/generate-proto.sh
./hack/update-codegen.sh
make api/openapi-spec/swagger.json
find . -path '*/mocks/*' -type f -not -path '*/vendor/*' -exec ./hack/update-mocks.sh {} ';'
rm -rf ./vendor
go mod tidy
.PHONY: manifests
manifests: status manifests/install.yaml manifests/namespace-install.yaml manifests/quick-start-mysql.yaml manifests/quick-start-postgres.yaml manifests/quick-start-no-db.yaml test/e2e/manifests/postgres.yaml test/e2e/manifests/mysql.yaml test/e2e/manifests/no-db.yaml
# we use a different file to ./VERSION to force updating manifests after a `make clean`
dist/MANIFESTS_VERSION:
mkdir -p dist
echo $(MANIFESTS_VERSION) > dist/MANIFESTS_VERSION
manifests/install.yaml: dist/MANIFESTS_VERSION $(MANIFESTS)
kustomize build --load_restrictor=LoadRestrictionsNone manifests/cluster-install | sed "s/:latest/:$(MANIFESTS_VERSION)/" | ./hack/auto-gen-msg.sh > manifests/install.yaml
manifests/namespace-install.yaml: dist/MANIFESTS_VERSION $(MANIFESTS)
kustomize build --load_restrictor=LoadRestrictionsNone manifests/namespace-install | sed "s/:latest/:$(MANIFESTS_VERSION)/" | ./hack/auto-gen-msg.sh > manifests/namespace-install.yaml
manifests/quick-start-no-db.yaml: dist/MANIFESTS_VERSION $(MANIFESTS)
kustomize build --load_restrictor=LoadRestrictionsNone manifests/quick-start/no-db | sed "s/:latest/:$(MANIFESTS_VERSION)/" | ./hack/auto-gen-msg.sh > manifests/quick-start-no-db.yaml
manifests/quick-start-mysql.yaml: dist/MANIFESTS_VERSION $(MANIFESTS)
kustomize build --load_restrictor=LoadRestrictionsNone manifests/quick-start/mysql | sed "s/:latest/:$(MANIFESTS_VERSION)/" | ./hack/auto-gen-msg.sh > manifests/quick-start-mysql.yaml
manifests/quick-start-postgres.yaml: dist/MANIFESTS_VERSION $(MANIFESTS)
kustomize build --load_restrictor=LoadRestrictionsNone manifests/quick-start/postgres | sed "s/:latest/:$(MANIFESTS_VERSION)/" | ./hack/auto-gen-msg.sh > manifests/quick-start-postgres.yaml
# lint/test/etc
$(HOME)/go/bin/golangci-lint:
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.23.8
.PHONY: lint
lint: server/static/files.go $(HOME)/go/bin/golangci-lint
# Tidy Go modules
go mod tidy
# Lint Go files
golangci-lint run --fix --verbose --concurrency 4 --timeout 5m
ifeq ($(CI),false)
# Lint UI files
yarn --cwd ui lint
endif
.PHONY: test
test: server/static/files.go
# Run unit tests
ifeq ($(CI),false)
go test `go list ./... | grep -v 'test/e2e'`
else
go test -covermode=count -coverprofile=coverage.out `go list ./... | grep -v 'test/e2e'`
endif
test/e2e/manifests/postgres.yaml: $(MANIFESTS) $(E2E_MANIFESTS)
# Create Postgres e2e manifests
kustomize build --load_restrictor=LoadRestrictionsNone test/e2e/manifests/postgres | ./hack/auto-gen-msg.sh > test/e2e/manifests/postgres.yaml
dist/postgres.yaml: test/e2e/manifests/postgres.yaml
# Create Postgres e2e manifests
cat test/e2e/manifests/postgres.yaml | sed 's/:latest/:$(VERSION)/' | sed 's/pns/$(E2E_EXECUTOR)/' > dist/postgres.yaml
test/e2e/manifests/no-db/overlays/argo-server-deployment.yaml: test/e2e/manifests/postgres/overlays/argo-server-deployment.yaml
test/e2e/manifests/no-db/overlays/argo-server-deployment.yaml:
cat test/e2e/manifests/postgres/overlays/argo-server-deployment.yaml | ./hack/auto-gen-msg.sh > test/e2e/manifests/no-db/overlays/argo-server-deployment.yaml
test/e2e/manifests/no-db/overlays/workflow-controller-deployment.yaml: test/e2e/manifests/postgres/overlays/workflow-controller-deployment.yaml
test/e2e/manifests/no-db/overlays/workflow-controller-deployment.yaml:
cat test/e2e/manifests/postgres/overlays/workflow-controller-deployment.yaml | ./hack/auto-gen-msg.sh > test/e2e/manifests/no-db/overlays/workflow-controller-deployment.yaml
test/e2e/manifests/no-db.yaml: $(MANIFESTS) $(E2E_MANIFESTS)
# Create no DB e2e manifests
kustomize build --load_restrictor=LoadRestrictionsNone test/e2e/manifests/no-db | ./hack/auto-gen-msg.sh > test/e2e/manifests/no-db.yaml
dist/no-db.yaml: test/e2e/manifests/no-db.yaml
# Create no DB e2e manifests
# We additionlly disable ALWAY_OFFLOAD_NODE_STATUS
cat test/e2e/manifests/no-db.yaml | sed 's/:latest/:$(VERSION)/' | sed 's/pns/$(E2E_EXECUTOR)/' | sed 's/"true"/"false"/' > dist/no-db.yaml
test/e2e/manifests/mysql.yaml: $(MANIFESTS) $(E2E_MANIFESTS)
# Create MySQL e2e manifests
kustomize build --load_restrictor=LoadRestrictionsNone test/e2e/manifests/mysql | ./hack/auto-gen-msg.sh > test/e2e/manifests/mysql.yaml
dist/mysql.yaml: test/e2e/manifests/mysql.yaml
# Create MySQL e2e manifests
cat test/e2e/manifests/mysql.yaml | sed 's/:latest/:$(VERSION)/' | sed 's/pns/$(E2E_EXECUTOR)/' > dist/mysql.yaml
.PHONY: install
install: dist/postgres.yaml dist/mysql.yaml dist/no-db.yaml
# Install Postgres quick-start
kubectl get ns argo || kubectl create ns argo
ifeq ($(DB),postgres)
kubectl -n argo apply -f dist/postgres.yaml
else
ifeq ($(DB),mysql)
kubectl -n argo apply -f dist/mysql.yaml
else
kubectl -n argo apply -f dist/no-db.yaml
endif
endif
.PHONY: test-images
test-images: dist/cowsay-v1 dist/bitnami-kubectl-1.15.3-ol-7-r165 dist/python-alpine3.6
dist/cowsay-v1:
docker build -t cowsay:v1 test/e2e/images/cowsay
ifeq ($(K3D),true)
k3d import-images cowsay:v1
endif
touch dist/cowsay-v1
dist/bitnami-kubectl-1.15.3-ol-7-r165:
docker pull bitnami/kubectl:1.15.3-ol-7-r165
touch dist/bitnami-kubectl-1.15.3-ol-7-r165
dist/python-alpine3.6:
docker pull python:alpine3.6
touch dist/python-alpine3.6
.PHONY: start
start: status install down controller-image cli-image executor-image wait-down up cli wait-up env
# Switch to "argo" ns.
kubectl config set-context --current --namespace=argo
.PHONY: down
down:
# Scale down
kubectl -n argo scale deployment/argo-server --replicas 0
kubectl -n argo scale deployment/workflow-controller --replicas 0
.PHONY: wait-down
wait-down:
# Wait for pods to go away, so we don't wait for them to be ready later.
[ "`kubectl -n argo get pod -l app=argo-server -o name`" = "" ] || kubectl -n argo wait --for=delete pod -l app=argo-server --timeout 30s
[ "`kubectl -n argo get pod -l app=workflow-controller -o name`" = "" ] || kubectl -n argo wait --for=delete pod -l app=workflow-controller --timeout 2m
.PHONY: up
up:
# Scale up
kubectl -n argo scale deployment/workflow-controller --replicas 1
kubectl -n argo scale deployment/argo-server --replicas 1
.PHONY: wait-up
wait-up:
# Wait for pods to be ready
kubectl -n argo wait --for=condition=Ready pod --all -l app --timeout 2m
# this is a convenience to get the login token, you can use it as follows
# eval $(make env)
# argo token
.PHONY: env
env:
export ARGO_SERVER=localhost:2746
export ARGO_TOKEN=$(ARGO_TOKEN)
.PHONY: pf
pf:
# Start port-forwards
./hack/port-forward.sh
.PHONY: pf-bg
pf-bg:
# Start port-forwards in the background
./hack/port-forward.sh &
.PHONY: logs
logs:
# Tail logs
kubectl -n argo logs -f -l app --max-log-requests 10 --tail 100
.PHONY: postgres-cli
postgres-cli:
kubectl exec -ti `kubectl get pod -l app=postgres -o name|cut -c 5-` -- psql -U postgres
.PHONY: mysql-cli
mysql-cli:
kubectl exec -ti `kubectl get pod -l app=mysql -o name|cut -c 5-` -- mysql -u mysql -ppassword argo
.PHONY: test-e2e
test-e2e: test-images cli
# Run E2E tests
go test -timeout 20m -v -count 1 -p 1 ./test/e2e/...
.PHONY: smoke
smoke: test-images
# Run smoke tests
go test -timeout 2m -v -count 1 -p 1 -run SmokeSuite ./test/e2e
.PHONY: test-api
test-api: test-images
# Run API tests
go test -timeout 3m -v -count 1 -p 1 -run ArgoServerSuite ./test/e2e
.PHONY: test-cli
test-cli: test-images cli
# Run CLI tests
go test -timeout 1m -v -count 1 -p 1 -run CLISuite ./test/e2e
go test -timeout 1m -v -count 1 -p 1 -run CLIWithServerSuite ./test/e2e
# clean
.PHONY: clean
clean:
# Delete pre-go 1.3 vendor
rm -Rf vendor
# Delete build files
rm -Rf dist/* ui/dist
# swagger
$(HOME)/go/bin/swagger:
go get github.com/go-swagger/go-swagger/cmd/swagger
api/openapi-spec/swagger.json: $(HOME)/go/bin/swagger $(SWAGGER_FILES) dist/MANIFESTS_VERSION hack/swaggify.sh
swagger mixin -c 412 $(SWAGGER_FILES) | sed 's/VERSION/$(MANIFESTS_VERSION)/' | ./hack/swaggify.sh > api/openapi-spec/swagger.json
# pre-push
.PHONY: pre-commit
pre-commit: test lint codegen manifests start pf-bg smoke test-api test-cli
# release - targets only available on release branch
ifneq ($(findstring release,$(GIT_BRANCH)),)
.PHONY: prepare-release
prepare-release: clean codegen manifests
# Commit if any changes
git diff --quiet || git commit -am "Update manifests to $(VERSION)"
git tag $(VERSION)
.PHONY: publish-release
publish-release: build
# Push images to Docker Hub
docker push $(IMAGE_NAMESPACE)/argocli:$(VERSION)
docker push $(IMAGE_NAMESPACE)/argoexec:$(VERSION)
docker push $(IMAGE_NAMESPACE)/workflow-controller:$(VERSION)
git push
git push $(GIT_REMOTE) $(VERSION)
endif