Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use go-enry for language detection #1500

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore: Use go-enry for language detection #1500

merged 1 commit into from
Jul 12, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Jul 12, 2024

Description:

Use go-enry for language detection because it's better supported.

Related Issues:

Fixes #518 #1009

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.81%. Comparing base (6ee63ce) to head (ee8d85d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
- Coverage   79.16%   78.81%   -0.36%     
==========================================
  Files          15       15              
  Lines         907      892      -15     
==========================================
- Hits          718      703      -15     
  Misses        138      138              
  Partials       51       51              
Files Coverage Δ
internal/scanner/scanner.go 76.97% <100.00%> (-1.18%) ⬇️
internal/walker/walker.go 60.36% <100.00%> (ø)

@ianlewis ianlewis changed the title Use go-enry for language detection chore: Use go-enry for language detection Jul 12, 2024
@ianlewis ianlewis force-pushed the enry branch 2 times, most recently from d3ca1bd to 3b16143 Compare July 12, 2024 09:33
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit cbc2d3f into main Jul 12, 2024
14 checks passed
@ianlewis ianlewis deleted the enry branch July 12, 2024 09:40
@ianlewis ianlewis mentioned this pull request Jul 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Detect language by filename
1 participant