Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: RuneReader #842

Merged
merged 2 commits into from
Oct 3, 2023
Merged

refactor: RuneReader #842

merged 2 commits into from
Oct 3, 2023

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Oct 3, 2023

Description:

Refactors the RuneReader by moving it to it's own package and removes the internal byte buffer in favor of using bufio.Reader.

Related Issues:

Fixes #441

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #842 (8cce22e) into main (10063f2) will increase coverage by 1.28%.
The diff coverage is 82.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   80.76%   82.05%   +1.28%     
==========================================
  Files          19       19              
  Lines        1144     1120      -24     
  Branches       14       14              
==========================================
- Hits          924      919       -5     
+ Misses        158      146      -12     
+ Partials       62       55       -7     
Files Coverage Δ
internal/utils/slice.go 100.00% <100.00%> (ø)
internal/runes/reader.go 89.47% <89.47%> (ø)
internal/scanner/scanner.go 77.70% <38.46%> (ø)

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 4a3aa48 into main Oct 3, 2023
26 checks passed
@ianlewis ianlewis deleted the runereader-refactor-1 branch October 3, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RuneReader
1 participant