From 0d8fee5cce442b051c9ddf5fd83dbafdc4a45175 Mon Sep 17 00:00:00 2001
From: Lukasz Ostafin <ostafin.lucas@gmail.com>
Date: Wed, 28 Aug 2024 15:54:53 +0200
Subject: [PATCH] After CR

---
 .../config/universal_discovery_widget.yaml    |   9 -
 .../hooks/useSearchByQueryFetch.js            |   2 +-
 .../universal.discovery.module.js             | 185 ++++++++----------
 3 files changed, 87 insertions(+), 109 deletions(-)

diff --git a/src/bundle/Resources/config/universal_discovery_widget.yaml b/src/bundle/Resources/config/universal_discovery_widget.yaml
index 1b0f5dc1af..32feca3396 100644
--- a/src/bundle/Resources/config/universal_discovery_widget.yaml
+++ b/src/bundle/Resources/config/universal_discovery_widget.yaml
@@ -35,15 +35,6 @@ system:
                         browse:
                             items_per_page: 50
                             priority: 30
-                    image_picker_tabs_config:
-                        image_picker:
-                            id: 'image_picker'
-                            priority: 40
-                            hidden: false
-                        image_picker_bookmarks:
-                            id: 'image_picker_bookmarks'
-                            priority: 50
-                            hidden: false
 
                 # These inherit _default configuration
                 create:
diff --git a/src/bundle/ui-dev/src/modules/universal-discovery/hooks/useSearchByQueryFetch.js b/src/bundle/ui-dev/src/modules/universal-discovery/hooks/useSearchByQueryFetch.js
index 638de99757..f9d615e836 100644
--- a/src/bundle/ui-dev/src/modules/universal-discovery/hooks/useSearchByQueryFetch.js
+++ b/src/bundle/ui-dev/src/modules/universal-discovery/hooks/useSearchByQueryFetch.js
@@ -83,7 +83,7 @@ export const useSearchByQueryFetch = () => {
             }
 
             if (isBookmarked) {
-                query.IsBookmarkedCriterion = isBookmarked;
+                query.IsBookmarkedCriterion = true;
             }
 
             const isImageCriterionDataEmpty = !imageCriterionData || Object.keys(imageCriterionData).length === 0;
diff --git a/src/bundle/ui-dev/src/modules/universal-discovery/universal.discovery.module.js b/src/bundle/ui-dev/src/modules/universal-discovery/universal.discovery.module.js
index 64718fa142..b3343578e1 100644
--- a/src/bundle/ui-dev/src/modules/universal-discovery/universal.discovery.module.js
+++ b/src/bundle/ui-dev/src/modules/universal-discovery/universal.discovery.module.js
@@ -196,7 +196,6 @@ export const DropdownPortalRefContext = createContext();
 export const SuggestionsStorageContext = createContext();
 export const GridActiveLocationIdContext = createContext();
 export const SnackbarActionsContext = createContext();
-export const ImagePickerTabsConfigContext = createContext();
 
 const UniversalDiscoveryModule = (props) => {
     const { restInfo } = props;
@@ -475,120 +474,116 @@ const UniversalDiscoveryModule = (props) => {
                                         <MultipleConfigContext.Provider value={[props.multiple, props.multipleItemsLimit]}>
                                             <ContainersOnlyContext.Provider value={props.containersOnly}>
                                                 <AllowedContentTypesContext.Provider value={props.allowedContentTypes}>
-                                                    <ImagePickerTabsConfigContext.Provider value={props.imagePickerTabsConfig}>
-                                                        <SnackbarActionsContext.Provider value={props.snackbarEnabledActions}>
-                                                            <ActiveTabContext.Provider
-                                                                value={[activeTab, setActiveTab, previousActiveTab, props.activeTab]}
-                                                            >
-                                                                <TabsContext.Provider value={tabs}>
-                                                                    <TabsConfigContext.Provider value={props.tabsConfig}>
-                                                                        <TitleContext.Provider value={props.title}>
-                                                                            <CancelContext.Provider value={props.onCancel}>
-                                                                                <ConfirmContext.Provider value={onConfirm}>
-                                                                                    <SortingContext.Provider value={[sorting, setSorting]}>
-                                                                                        <SortOrderContext.Provider
-                                                                                            value={[sortOrder, setSortOrder]}
+                                                    <SnackbarActionsContext.Provider value={props.snackbarEnabledActions}>
+                                                        <ActiveTabContext.Provider
+                                                            value={[activeTab, setActiveTab, previousActiveTab, props.activeTab]}
+                                                        >
+                                                            <TabsContext.Provider value={tabs}>
+                                                                <TabsConfigContext.Provider value={props.tabsConfig}>
+                                                                    <TitleContext.Provider value={props.title}>
+                                                                        <CancelContext.Provider value={props.onCancel}>
+                                                                            <ConfirmContext.Provider value={onConfirm}>
+                                                                                <SortingContext.Provider value={[sorting, setSorting]}>
+                                                                                    <SortOrderContext.Provider
+                                                                                        value={[sortOrder, setSortOrder]}
+                                                                                    >
+                                                                                        <CurrentViewContext.Provider
+                                                                                            value={[currentView, setCurrentView]}
                                                                                         >
-                                                                                            <CurrentViewContext.Provider
-                                                                                                value={[currentView, setCurrentView]}
+                                                                                            <MarkedLocationIdContext.Provider
+                                                                                                value={[
+                                                                                                    markedLocationId,
+                                                                                                    setMarkedLocationId,
+                                                                                                ]}
                                                                                             >
-                                                                                                <MarkedLocationIdContext.Provider
-                                                                                                    value={[
-                                                                                                        markedLocationId,
-                                                                                                        setMarkedLocationId,
-                                                                                                    ]}
+                                                                                                <StartingLocationIdContext.Provider
+                                                                                                    value={props.startingLocationId}
                                                                                                 >
-                                                                                                    <StartingLocationIdContext.Provider
-                                                                                                        value={props.startingLocationId}
+                                                                                                    <GridActiveLocationIdContext.Provider
+                                                                                                        value={[
+                                                                                                            gridActiveLocationId,
+                                                                                                            setGridActiveLocationId,
+                                                                                                        ]}
                                                                                                     >
-                                                                                                        <GridActiveLocationIdContext.Provider
+                                                                                                        <LoadedLocationsMapContext.Provider
                                                                                                             value={[
-                                                                                                                gridActiveLocationId,
-                                                                                                                setGridActiveLocationId,
+                                                                                                                loadedLocationsMap,
+                                                                                                                dispatchLoadedLocationsAction,
                                                                                                             ]}
                                                                                                         >
-                                                                                                            <LoadedLocationsMapContext.Provider
-                                                                                                                value={[
-                                                                                                                    loadedLocationsMap,
-                                                                                                                    dispatchLoadedLocationsAction,
-                                                                                                                ]}
+                                                                                                            <RootLocationIdContext.Provider
+                                                                                                                value={props.rootLocationId}
                                                                                                             >
-                                                                                                                <RootLocationIdContext.Provider
-                                                                                                                    value={
-                                                                                                                        props.rootLocationId
-                                                                                                                    }
+                                                                                                                <SelectedLocationsContext.Provider
+                                                                                                                    value={[
+                                                                                                                        selectedLocations,
+                                                                                                                        dispatchSelectedLocationsAction,
+                                                                                                                    ]}
                                                                                                                 >
-                                                                                                                    <SelectedLocationsContext.Provider
+                                                                                                                    <CreateContentWidgetContext.Provider
                                                                                                                         value={[
-                                                                                                                            selectedLocations,
-                                                                                                                            dispatchSelectedLocationsAction,
+                                                                                                                            createContentVisible,
+                                                                                                                            setCreateContentVisible,
                                                                                                                         ]}
                                                                                                                     >
-                                                                                                                        <CreateContentWidgetContext.Provider
+                                                                                                                        <SuggestionsStorageContext.Provider
                                                                                                                             value={[
-                                                                                                                                createContentVisible,
-                                                                                                                                setCreateContentVisible,
+                                                                                                                                suggestionsStorage,
+                                                                                                                                setSuggestionsStorage,
                                                                                                                             ]}
                                                                                                                         >
-                                                                                                                            <SuggestionsStorageContext.Provider
+                                                                                                                            <ContentOnTheFlyDataContext.Provider
                                                                                                                                 value={[
-                                                                                                                                    suggestionsStorage,
-                                                                                                                                    setSuggestionsStorage,
+                                                                                                                                    contentOnTheFlyData,
+                                                                                                                                    setContentOnTheFlyData,
                                                                                                                                 ]}
                                                                                                                             >
-                                                                                                                                <ContentOnTheFlyDataContext.Provider
-                                                                                                                                    value={[
-                                                                                                                                        contentOnTheFlyData,
-                                                                                                                                        setContentOnTheFlyData,
-                                                                                                                                    ]}
+                                                                                                                                <ContentOnTheFlyConfigContext.Provider
+                                                                                                                                    value={
+                                                                                                                                        props.contentOnTheFly
+                                                                                                                                    }
                                                                                                                                 >
-                                                                                                                                    <ContentOnTheFlyConfigContext.Provider
-                                                                                                                                        value={
-                                                                                                                                            props.contentOnTheFly
-                                                                                                                                        }
+                                                                                                                                    <EditOnTheFlyDataContext.Provider
+                                                                                                                                        value={[
+                                                                                                                                            editOnTheFlyData,
+                                                                                                                                            setEditOnTheFlyData,
+                                                                                                                                        ]}
                                                                                                                                     >
-                                                                                                                                        <EditOnTheFlyDataContext.Provider
+                                                                                                                                        <SearchTextContext.Provider
                                                                                                                                             value={[
-                                                                                                                                                editOnTheFlyData,
-                                                                                                                                                setEditOnTheFlyData,
+                                                                                                                                                searchText,
+                                                                                                                                                setSearchText,
                                                                                                                                             ]}
                                                                                                                                         >
-                                                                                                                                            <SearchTextContext.Provider
-                                                                                                                                                value={[
-                                                                                                                                                    searchText,
-                                                                                                                                                    setSearchText,
-                                                                                                                                                ]}
+                                                                                                                                            <DropdownPortalRefContext.Provider
+                                                                                                                                                value={
+                                                                                                                                                    dropdownPortalRef
+                                                                                                                                                }
                                                                                                                                             >
-                                                                                                                                                <DropdownPortalRefContext.Provider
-                                                                                                                                                    value={
-                                                                                                                                                        dropdownPortalRef
-                                                                                                                                                    }
-                                                                                                                                                >
-                                                                                                                                                    <Tab />
-                                                                                                                                                </DropdownPortalRefContext.Provider>
-                                                                                                                                            </SearchTextContext.Provider>
-                                                                                                                                        </EditOnTheFlyDataContext.Provider>
-                                                                                                                                    </ContentOnTheFlyConfigContext.Provider>
-                                                                                                                                </ContentOnTheFlyDataContext.Provider>
-                                                                                                                            </SuggestionsStorageContext.Provider>
-                                                                                                                        </CreateContentWidgetContext.Provider>
-                                                                                                                    </SelectedLocationsContext.Provider>
-                                                                                                                </RootLocationIdContext.Provider>
-                                                                                                            </LoadedLocationsMapContext.Provider>
-                                                                                                        </GridActiveLocationIdContext.Provider>
-                                                                                                    </StartingLocationIdContext.Provider>
-                                                                                                </MarkedLocationIdContext.Provider>
-                                                                                            </CurrentViewContext.Provider>
-                                                                                        </SortOrderContext.Provider>
-                                                                                    </SortingContext.Provider>
-                                                                                </ConfirmContext.Provider>
-                                                                            </CancelContext.Provider>
-                                                                        </TitleContext.Provider>
-                                                                    </TabsConfigContext.Provider>
-                                                                </TabsContext.Provider>
-                                                            </ActiveTabContext.Provider>
-                                                        </SnackbarActionsContext.Provider>
-                                                    </ImagePickerTabsConfigContext.Provider>
+                                                                                                                                                <Tab />
+                                                                                                                                            </DropdownPortalRefContext.Provider>
+                                                                                                                                        </SearchTextContext.Provider>
+                                                                                                                                    </EditOnTheFlyDataContext.Provider>
+                                                                                                                                </ContentOnTheFlyConfigContext.Provider>
+                                                                                                                            </ContentOnTheFlyDataContext.Provider>
+                                                                                                                        </SuggestionsStorageContext.Provider>
+                                                                                                                    </CreateContentWidgetContext.Provider>
+                                                                                                                </SelectedLocationsContext.Provider>
+                                                                                                            </RootLocationIdContext.Provider>
+                                                                                                        </LoadedLocationsMapContext.Provider>
+                                                                                                    </GridActiveLocationIdContext.Provider>
+                                                                                                </StartingLocationIdContext.Provider>
+                                                                                            </MarkedLocationIdContext.Provider>
+                                                                                        </CurrentViewContext.Provider>
+                                                                                    </SortOrderContext.Provider>
+                                                                                </SortingContext.Provider>
+                                                                            </ConfirmContext.Provider>
+                                                                        </CancelContext.Provider>
+                                                                    </TitleContext.Provider>
+                                                                </TabsConfigContext.Provider>
+                                                            </TabsContext.Provider>
+                                                        </ActiveTabContext.Provider>
+                                                    </SnackbarActionsContext.Provider>
                                                 </AllowedContentTypesContext.Provider>
                                             </ContainersOnlyContext.Provider>
                                         </MultipleConfigContext.Provider>
@@ -643,13 +638,6 @@ UniversalDiscoveryModule.propTypes = {
         instanceUrl: PropTypes.string,
     }),
     snackbarEnabledActions: PropTypes.array,
-    imagePickerTabsConfig: PropTypes.objectOf(
-        PropTypes.shape({
-            id: PropTypes.string.isRequired,
-            priority: PropTypes.number.isRequired,
-            hidden: PropTypes.bool.isRequired,
-        }),
-    ),
 };
 
 UniversalDiscoveryModule.defaultProps = {
@@ -666,7 +654,6 @@ UniversalDiscoveryModule.defaultProps = {
     selectedLocations: [],
     restInfo: defaultRestInfo,
     snackbarEnabledActions: Object.values(SNACKBAR_ACTIONS),
-    imagePickerTabsConfig: {},
 };
 
 export default UniversalDiscoveryModule;