From 1e798338413637d82717a73135e54439bacb888d Mon Sep 17 00:00:00 2001 From: Lukasz Ostafin Date: Wed, 16 Feb 2022 13:57:52 +0100 Subject: [PATCH 1/2] IBX-1496: Creating a new language - the language code changed from a dropdown to input field in the new design --- .../Form/Type/FieldDefinition/FieldDefinitionType.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php b/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php index 7b05db3264..b474b5573a 100644 --- a/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php +++ b/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php @@ -14,9 +14,9 @@ use Ibexa\Core\Helper\FieldsGroups\FieldsGroupsList; use Symfony\Component\Form\AbstractType; use Symfony\Component\Form\Extension\Core\Type\CheckboxType; -use Symfony\Component\Form\Extension\Core\Type\ChoiceType; use Symfony\Component\Form\Extension\Core\Type\IntegerType; use Symfony\Component\Form\Extension\Core\Type\TextType; +use Symfony\Component\Form\Extension\Core\Type\HiddenType; use Symfony\Component\Form\FormBuilderInterface; use Symfony\Component\Form\FormEvent; use Symfony\Component\Form\FormEvents; @@ -120,13 +120,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) ]) ->add( 'fieldGroup', - ChoiceType::class, - [ - 'choices' => $fieldsGroups, - 'required' => false, - 'label' => /** @Desc("Category") */ 'field_definition.field_group', - 'disabled' => $isTranslation, - ] + HiddenType::class, ) ->add('position', IntegerType::class, [ 'label' => /** @Desc("Position") */ 'field_definition.position', From b62742d590d8393f047d190f5832cd6154e8933e Mon Sep 17 00:00:00 2001 From: Lukasz Ostafin Date: Mon, 21 Feb 2022 15:42:45 +0100 Subject: [PATCH 2/2] After CR --- src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php b/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php index b474b5573a..9ebf9f131e 100644 --- a/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php +++ b/src/lib/Form/Type/FieldDefinition/FieldDefinitionType.php @@ -14,9 +14,9 @@ use Ibexa\Core\Helper\FieldsGroups\FieldsGroupsList; use Symfony\Component\Form\AbstractType; use Symfony\Component\Form\Extension\Core\Type\CheckboxType; +use Symfony\Component\Form\Extension\Core\Type\HiddenType; use Symfony\Component\Form\Extension\Core\Type\IntegerType; use Symfony\Component\Form\Extension\Core\Type\TextType; -use Symfony\Component\Form\Extension\Core\Type\HiddenType; use Symfony\Component\Form\FormBuilderInterface; use Symfony\Component\Form\FormEvent; use Symfony\Component\Form\FormEvents; @@ -72,11 +72,6 @@ public function configureOptions(OptionsResolver $resolver) public function buildForm(FormBuilderInterface $builder, array $options) { - $fieldsGroups = []; - if (isset($this->groupsList)) { - $fieldsGroups = array_flip($this->groupsList->getGroups()); - } - $translatablePropertyTransformer = new TranslatablePropertyTransformer($options['languageCode']); $isTranslation = $options['languageCode'] !== $options['mainLanguageCode'];