Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations Broken when mapped #1535

Closed
2 tasks done
rs017991 opened this issue Nov 13, 2022 · 0 comments · Fixed by #1536
Closed
2 tasks done

Operations Broken when mapped #1535

rs017991 opened this issue Nov 13, 2022 · 0 comments · Fixed by #1536
Labels
bug Something isn't working shell
Milestone
0.6.0

Comments

@rs017991
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

When you call .map on an Operation, the operation is silently ignored.

You can reproduce the issue by running these modified examples.

  • In the case of the scrollable example: the 'Scroll to top/bottom' buttons no longer function
  • In the case of the todo example: The various focusing behaviours no longer function

I've tracked this down to missing function implementations in MapRef.
I have a partial fix, and will open a PR shortly.

What is the expected behavior?

Operations should work when mapped to different message types

Version

master

Operative System

Windows

Do you have any log output?

No response
@rs017991 rs017991 added the bug Something isn't working label Nov 13, 2022
@rs017991 rs017991 mentioned this issue Nov 13, 2022
Merged
@rs017991 rs017991 changed the title Operations broken when mapped Operations Broken when mapped Nov 13, 2022
@hecrj hecrj added the shell label Nov 13, 2022
@hecrj hecrj added this to the 0.6.0 milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working shell
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Fix mapped Operation always returning Outcome::None rs017991/iced
2 participants
@hecrj @rs017991