Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cw wasm light client #754

Merged
merged 67 commits into from
May 15, 2024
Merged

feat: cw wasm light client #754

merged 67 commits into from
May 15, 2024

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Sep 27, 2023 •
edited
Loading

Description

Commit Message

feat: cw wasm light client

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@github-actions github-actions bot added documentation Improvements or additions to documentation scripts labels Sep 27, 2023
@ibrizsabin ibrizsabin self-assigned this Oct 2, 2023
@ibrizsabin ibrizsabin added Feature bump:minor and removed documentation Improvements or additions to documentation scripts labels Oct 2, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation scripts labels Oct 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.38272% with 124 lines in your changes are missing coverage. Please review.

Project coverage is 76.84%. Comparing base (c277c32) to head (25ee4a9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #754      +/-   ##
============================================
+ Coverage     76.28%   76.84%   +0.56%     
+ Complexity      418      409       -9     
============================================
  Files           155      157       +2     
  Lines         14447    14237     -210     
  Branches        292      288       -4     
============================================
- Hits          11021    10941      -80     
+ Misses         3279     3147     -132     
- Partials        147      149       +2
Flag Coverage Δ
rust 76.12% <69.38%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...osmwasm-vm/cw-ibc-core/src/ics02_client/handler.rs 97.91% <100.00%> (+<0.01%) ⬆️
...-vm/cw-ibc-core/src/ics03_connection/connection.rs 94.07% <100.00%> (+2.40%) ⬆️
...asm-vm/cw-ibc-core/src/ics03_connection/handler.rs 100.00% <100.00%> (ø)
...smwasm-vm/cw-ibc-core/src/ics04_channel/handler.rs 100.00% <100.00%> (ø)
...c-core/src/ics04_channel/packet/acknowledgement.rs 97.52% <100.00%> (ø)
...bc-core/src/ics04_channel/packet/receive_packet.rs 97.72% <100.00%> (+0.02%) ⬆️
...w-ibc-core/src/ics04_channel/packet/send_packet.rs 100.00% <100.00%> (ø)
...-core/src/ics04_channel/packet/timeout_on_close.rs 100.00% <100.00%> (ø)
...ts/cosmwasm-vm/cw-icon-light-client/src/context.rs 100.00% <100.00%> (ø)
...s/cosmwasm-vm/cw-icon-light-client/src/contract.rs 66.01% <ø> (-0.09%) ⬇️
... and 15 more

... and 21 files with indirect coverage changes

AntonAndell
AntonAndell requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, looks good. Going to do another pass later which compares to our current client doc.

contracts/cosmwasm-vm/cw-wasm-light-client/src/contract.rs Outdated Show resolved Hide resolved
contracts/cosmwasm-vm/cw-wasm-light-client/src/contract.rs Show resolved Hide resolved
ibrizsabin and others added 15 commits January 29, 2024 02:49
@ibrizsabin
fix:resolve comments
763fd48
@ibrizsabin
chore: pass build
c121bfd
@ibrizsabin
fix: remove unnecessary hash
71f1126
@ibrizsabin
chore: pass build
2b04afa
@ibrizsabin
fix: rename client id
c3dd121
@AntonAndell
fix: Fix reverse sign on timestamp check for request timeout
9497615
@bishalbikram
chore: update test coverage for ibc client (#846)
9a7876b
@bishalbikram
chore: update test coverage for ics03-connection (#848)
670e92e 
* chore: update test coverage for ibc client

* chore: improve test coverage for ibc connection
@bishalbikram
chore: add test coverage for cosmwasm ibc core (#850)
8a30139
@AntonAndell
docs: Add explanation on how a connection can be manually verified (#838
17ce339 
)

doc: Add explanation on how a connection can be manually verified
fix: add reference to CI workflow to fix error (#839)
5bd6c10 
Co-authored-by: ForwardSlashBack <ForwardSlashBack@users.noreply.github.com>
@bishalbikram
chore: add unit test coverage for icon light client (#851)
545da5c
@DeepakBomjan
ci: add injectived, and neutornd binary (#858)
8160977 
* ci: add injectived, and neutornd binary

* ci: update archwayd to v6.0.0

* ci: update archwayd to v6.0.0
@bishalbikram
chore: add test coverage for xcall-ibc-connection (#853)
c277c32
@ibrizsabin
chore: fix merge conflicts
c0d2f96
@ibrizsabin ibrizsabin requested a review from nightowl121 May 9, 2024 06:14
nightowl121
nightowl121 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@nightowl121 nightowl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ibrizsabin ibrizsabin requested a review from AntonAndell May 15, 2024 05:20
@ibrizsabin ibrizsabin changed the base branch from main to feature/wasm-lightclient-ibc-changes May 15, 2024 05:21
@github-actions github-actions bot added the cicd label May 15, 2024
@ibrizsabin ibrizsabin merged commit 9d25c2e into feature/wasm-lightclient-ibc-changes May 15, 2024
8 checks passed
@ibrizsabin ibrizsabin deleted the feat/cw-wasm-light-client branch May 15, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightowl121 nightowl121 nightowl121 approved these changes

@redlarva redlarva Awaiting requested review from redlarva

@AntonAndell AntonAndell Awaiting requested review from AntonAndell AntonAndell is a code owner

Assignees

@ibrizsabin ibrizsabin

Labels
bump:minor cicd documentation Improvements or additions to documentation Feature scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hopchain - Relay and Lightclient Integration Lightclient translation
6 participants
@ibrizsabin @codecov-commenter @AntonAndell @nightowl121 @bishalbikram @DeepakBomjan