Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement receive packet #271

Merged

Conversation

shanithkk
Copy link
Collaborator

Description:

As a developer, I want to be able to receive packets from the counterparty using the recvPacket function, and handle them appropriately, such as by acknowledging receipt or retransmitting them if necessary.

Commit Message

feat: implement receive packet

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #271 (d6e46bd) into main (9660970) will increase coverage by 1.37%.
The diff coverage is 73.12%.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   44.85%   46.23%   +1.37%     
==========================================
  Files          90       91       +1     
  Lines       14595    14941     +346     
==========================================
+ Hits         6547     6908     +361     
+ Misses       8048     8033      -15     
Impacted Files Coverage Δ
...osmwasm-vm/cw-ibc-core/src/ics04_channel/packet.rs 0.00% <ø> (ø)
contracts/cosmwasm-vm/cw-ibc-core/src/lib.rs 3.22% <ø> (ø)
contracts/cosmwasm-vm/cw-ibc-core/src/msg.rs 20.00% <ø> (ø)
...bc-core/src/ics04_channel/packet/recieve_packet.rs 72.80% <72.80%> (ø)
contracts/cosmwasm-vm/cw-ibc-core/src/types.rs 79.85% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shreyasbhat0 shreyasbhat0 merged commit 2577dca into icon-project:main Apr 13, 2023
@shreyasbhat0 shreyasbhat0 deleted the feature/implement-receive-packet-#110 branch April 13, 2023 06:24
ibrizsabin pushed a commit that referenced this pull request Feb 23, 2024
…tandard-unit-test-improvments

feat: improvements on xcall2.1 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants