Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIBC 37 Implement connection library #38

Merged
merged 3 commits into from
Feb 23, 2023
Merged

IIBC 37 Implement connection library #38

merged 3 commits into from
Feb 23, 2023

Conversation

AntonAndell
Copy link
Collaborator

Description:

Initial Implementation and unit test of Connection library ICS-03.
Dependencies on IBC-HOST have been commented and will be resolved later.

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@linear
Copy link

linear bot commented Feb 23, 2023

IIBC-37 ICON - Handler - Connection

  1. ConnectionOpenInit
  2. ConnectionOpenTry
  3. ConnectionOpenAck
  4. ConnectionOpenConfirm

@AntonAndell AntonAndell requested a review from redlarva February 23, 2023 05:26
@redlarva redlarva merged commit b5f0b6c into feature/IIBC-36-implement-client-library Feb 23, 2023
@redlarva redlarva deleted the feature/IIBC-37-implement-connection-library branch February 23, 2023 14:59
nightowl121 added a commit that referenced this pull request Mar 9, 2023
@AntonAndell @hemz10
@Prathiksha-Nataraja @shreyasbhat0 @nightowl121 @viveksharmapoudel @MuhammedIrfan
feat: IIBC 36 Implement client library (#36)
8cf16fa 
* Add Java classes to parse JSON versions of IBC proto messages

* Add Java classes to represent messages from [ICS-26](https://github.com/cosmos/ibc/tree/main/spec/core/ics-026-routing-module#datagram-handlers-write)
Translated from interperation done in https://github.com/hyperledger-labs/yui-ibc-solidity/blob/main/contracts/core/25-handler/IBCMsgs.sol

* Add Java classes to parse JSON versions of IBC proto messages

Add RLP encoding to proto messages used in storage

* downrgrade javaeeUnittestVersion from 0.10.0 to 0.9.7

* feat: implement create keys for signing transaction  (#27)

fezt : Create keys

Co-authored-by: hemz10 <sph2740@example.com>

* feat: implement callrequest storage (#24)

* chore: add boilerplate for cosmwasm-contracts

* update cargo

* test: add unit-test setup

* test: setup mock env

* update test

* update test setup, cargo

* add call service message

* chore: inital ibc impl for xcall

* chore:  refactor message and address

* chore: implement state for xcall

* chore: update call service  message

* chore: add call message request storage

* chore: add call message response storage

* chore: add rust rlp library

* chore: update cargo

* remove admin and owner

* add storage key enum

* update types

* remove admin and owner management

* chore : restructure contract state and update methods

* update admin and owner store

* add storage key for cosmwasm persistant storage

* add rollback message

* Initial commit

* removed encodable and decodable

* format code

* format code

* chore: remove rollback

---------

Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>

* Feature/add gradle properties for version in java contracts (#28)

* chore: upgrade gradle version to 8.0

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* chore: add common version of java libraries for smart contracts

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* Add ci to run while updating java contracts (#29)

* chore: add ci to run while updating java contracts

checks will run unit tests and optimize jar tasks

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* fix: fix command location for testing java contracts

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* docs: ADR for relay (#21)

* feat: implement call message response storage (#18)

* chore: add boilerplate for cosmwasm-contracts

* update cargo

* test: add unit-test setup

* test: setup mock env

* update test

* update test setup, cargo

* add call service message

* chore: inital ibc impl for xcall

* chore:  refactor message and address

* chore: implement state for xcall

* chore: update call service  message

* chore: add call message request storage

* chore: add call message response storage

* chore: add rust rlp library

* chore: update cargo

* remove admin and owner

* add storage key enum

* update types

* remove admin and owner management

* chore : restructure contract state and update methods

* update admin and owner store

* add storage key for cosmwasm persistant storage

* update rlp cargo

* implement request methods

* init rlp encode and decode for messages

* chore: cargo clippy

* chore: update owner and admin

* chore: add unit test

* chore: add unit test for request

---------

Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>

* downrgrade javaeeUnittestVersion from 0.10.0 to 0.9.7

* fix: fix folder name to run github actions

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* Import correct Version class in message classes

* modify gradle files and CI workflow to allow for CI builds

* Implement Client interferface/library for ICON handler
 * add to and from bytes to channel and connection end classes
 * add light client interface
 * add simple store class to use for now
 * add compare methods to height class

* Implement IBC handler message definitions as java classes (#32)

* Add Java classes to parse JSON versions of IBC proto messages

* Add Java classes to represent messages from [ICS-26](https://github.com/cosmos/ibc/tree/main/spec/core/ics-026-routing-module#datagram-handlers-write)
Translated from interperation done in https://github.com/hyperledger-labs/yui-ibc-solidity/blob/main/contracts/core/25-handler/IBCMsgs.sol

* feat: implement create keys for signing transaction  (#27)

fezt : Create keys

Co-authored-by: hemz10 <sph2740@example.com>

* feat: implement callrequest storage (#24)

* chore: add boilerplate for cosmwasm-contracts

* update cargo

* test: add unit-test setup

* test: setup mock env

* update test

* update test setup, cargo

* add call service message

* chore: inital ibc impl for xcall

* chore:  refactor message and address

* chore: implement state for xcall

* chore: update call service  message

* chore: add call message request storage

* chore: add call message response storage

* chore: add rust rlp library

* chore: update cargo

* remove admin and owner

* add storage key enum

* update types

* remove admin and owner management

* chore : restructure contract state and update methods

* update admin and owner store

* add storage key for cosmwasm persistant storage

* add rollback message

* Initial commit

* removed encodable and decodable

* format code

* format code

* chore: remove rollback

---------

Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>

* Feature/add gradle properties for version in java contracts (#28)

* chore: upgrade gradle version to 8.0

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* chore: add common version of java libraries for smart contracts

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* Add ci to run while updating java contracts (#29)

* chore: add ci to run while updating java contracts

checks will run unit tests and optimize jar tasks

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* fix: fix command location for testing java contracts

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* docs: ADR for relay (#21)

* feat: implement call message response storage (#18)

* chore: add boilerplate for cosmwasm-contracts

* update cargo

* test: add unit-test setup

* test: setup mock env

* update test

* update test setup, cargo

* add call service message

* chore: inital ibc impl for xcall

* chore:  refactor message and address

* chore: implement state for xcall

* chore: update call service  message

* chore: add call message request storage

* chore: add call message response storage

* chore: add rust rlp library

* chore: update cargo

* remove admin and owner

* add storage key enum

* update types

* remove admin and owner management

* chore : restructure contract state and update methods

* update admin and owner store

* add storage key for cosmwasm persistant storage

* update rlp cargo

* implement request methods

* init rlp encode and decode for messages

* chore: cargo clippy

* chore: update owner and admin

* chore: add unit test

* chore: add unit test for request

---------

Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>

* downrgrade javaeeUnittestVersion from 0.10.0 to 0.9.7

* fix: fix folder name to run github actions

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* Import correct Version class in message classes

* modify gradle files and CI workflow to allow for CI builds

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Hemanth Kumar <96766939+hemz10@users.noreply.github.com>
Co-authored-by: hemz10 <sph2740@example.com>
Co-authored-by: Prathiksha-Nataraja <90592522+Prathiksha-Nataraja@users.noreply.github.com>
Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>

* Add inital unittest, ignoring commitments

* IIBC 37 Implement connection library (#38)

* Add inital implementation of the Connection library for IBC Handler

* add connection unit tests, ignoring commitments and storage assertions

* IIBC 38 implement channel library (#39)

* Add inital implementation of the Connection library for IBC Handler

* Add inital implementation of the Channel library for IBC Handler

* Add inital unittest, ignoring commitments

* feat: implementing rollback message (#14)

* chore: add boilerplate for cosmwasm-contracts

* update cargo

* test: add unit-test setup

* test: setup mock env

* update test

* update test setup, cargo

* add call service message

* chore: inital ibc impl for xcall

* chore:  refactor message and address

* Initial commit

* chore: implement state for xcall

* Initial commit

* chore: update call service  message

* chore: add call message request storage

* chore: add call message response storage

* added methods

* implimenting rollback

* Added unit test case and code refactor

* code format

* updated testcase

* format new line

* chore: fix test rollback

* refactor function names

---------

Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>
Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>

* add connection unit tests, ignoring commitments and storage assertions

* Add channel handler and  send/recv package unit tests. Ignored commitments

* Apply commitments for IBC host branch

* add packet RLP encoding

* style: Apply style formatting by IDE

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* refactor: remove source set definition for build files

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* refactor: reduce DB reads

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Prathiksha-Nataraja <90592522+Prathiksha-Nataraja@users.noreply.github.com>
Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>
Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>

* style: add IDE formatting

Signed-off-by: Night Owl <nightowl121@protonmail.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Hemanth Kumar <96766939+hemz10@users.noreply.github.com>
Co-authored-by: hemz10 <sph2740@example.com>
Co-authored-by: Prathiksha-Nataraja <90592522+Prathiksha-Nataraja@users.noreply.github.com>
Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Co-authored-by: Shreyas S Bhat <35568964+shreyasbhat0@users.noreply.github.com>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: Muhammed Irfan <50794925+MuhammedIrfan@users.noreply.github.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>
@pragyanshrestha-ibriz pragyanshrestha-ibriz added iBriz iBriz Team ICON ICON Chain related task labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redlarva redlarva redlarva approved these changes

Assignees
No one assigned
Labels
iBriz iBriz Team ICON ICON Chain related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonAndell @redlarva @pragyanshrestha-ibriz