Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requiring couterpartyNid to be valid #653

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix: requiring couterpartyNid to be valid #653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a0a16
fix: requiring couterpartyNid to be valid
gcranju Aug 23, 2023
4c6d435
Fix lint
AntonAndell Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/javascore/xcall-connection/src/main/java/ibc/xcall/connection/IBCConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ public void onChanOpenTry(int order, String[] connectionHops, String portId, Str
String counterpartyPortId = counterparty.getPortId();
String counterPartyNid = configuredNetworkIds.at(connectionId).get(counterpartyPortId);
Context.require(portId.equals(PORT), "Invalid port");
Context.require(counterPartyNid!=null, "Invalid counterparty network id");
AntonAndell marked this conversation as resolved.
Show resolved Hide resolved
Context.require(channels.get(counterPartyNid) == null, "Network id is already configured");
lightClients.set(channelId, configuredClients.get(connectionId));
destinationPort.set(channelId, counterpartyPortId);
Expand Down