Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update xcall connection spec to match implementation #672

Merged

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Aug 29, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell force-pushed the 248-missing-logic-on-some-methods-in-xcall-connection branch from a16766e to e86ad85 Compare August 29, 2023 07:00
@AntonAndell AntonAndell changed the title fix: Update xcall connection spec to match xCall connection optimizat… fix: Update xcall connection spec to match implementation Aug 29, 2023
@AntonAndell AntonAndell force-pushed the 248-missing-logic-on-some-methods-in-xcall-connection branch from e86ad85 to 08ea4b6 Compare August 29, 2023 07:00
Copy link
Collaborator

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@redlarva redlarva requested a review from ibrizsabin August 29, 2023 08:09
@ibrizsabin ibrizsabin merged commit 775b784 into main Aug 29, 2023
@ibrizsabin ibrizsabin deleted the 248-missing-logic-on-some-methods-in-xcall-connection branch August 29, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants