Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: save write ack event height #734

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: save write ack event height #734

merged 3 commits into from
Sep 20, 2023

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Sep 20, 2023 •
edited
Loading

Description

Commit Message

feat: save write ack event height

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

viveksharmapoudel and others added 2 commits September 20, 2023 11:16
@viveksharmapoudel @izyak
feat: save write ack event height
303ad26
@nightowl121 @izyak
chore: style fixes
8e2805a 
Signed-off-by: Night Owl <nightowl121@protonmail.com>
@izyak izyak added the enhancement New feature or request label Sep 20, 2023
srmaharjan
srmaharjan approved these changes Sep 20, 2023
View reviewed changes
Copy link

@srmaharjan srmaharjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

redlarva
redlarva approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@redlarva redlarva merged commit 6eb6a85 into release Sep 20, 2023
21 of 22 checks passed
@redlarva redlarva deleted the feat/write-ack-heights branch September 20, 2023 06:00
@redlarva redlarva mentioned this pull request Sep 20, 2023
Closed
8 tasks
redlarva added a commit that referenced this pull request Oct 4, 2023
@ibrizsabin @viveksharmapoudel
@redlarva @izyak @nightowl121 @debendraoli @DeepakBomjan @sabinchitrakar @gcranju
fix: release conflicts (#765)
49ff4ad 
* fix: ibc query method get consensus state by height should return any type (#727)

* patch: ibc query method get consensus state by height should return any type

* fix: add uniformity

* feat: remove xcall multi submodule (#733)

* fix: remove xcall submodule

* refactor: update test execution script

* fix: update documentation

* feat: save write ack event height (#734)

* feat: save write ack event height

* chore: style fixes

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* fix: add test case

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>

* feat: test multiple packets on same height (#736)

* add(test): multiple packets on same heigt

* rf: simplfy recursion call

* ci: remove cw_common from inside the docker container (#712)

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* chore: exclude cosmwasm library and common file from contract deployment (#698)

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Debendra Oli <debendraoli@pm.me>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>

* feat: add write ack log (#700)

* feat: add write ack log

* chore: pass build

---------

Co-authored-by: sabinchitrakar <immortal.infidel@gmail.com>

* fix: point to xcall tag (#738)

* fix: point to xcall tag

* fix: xcall contract build script

---------

Co-authored-by: red__larva <red.x.larva@proton.me>

* fix: address decoding on fee claim (#741)

* fix: do not send fund to ibc core on send_call_message (#740)

* fix: do not send fund to ibc host on send call message

* fix: unit test

---------

Co-authored-by: ibrizsabin <sabin.chitrakar@ibriz.ai>

* feat: Add artifact checksum in release (#742)

* chore: pass build

* ci: cleanup release artifacts upload
* dynamically fetch wasm version
* chore: cleanup redundant steps from the workflow

---------

Co-authored-by: ibrizsabin <sabin.chitrakar@ibriz.ai>

* ci: fix download error (#744)

* ci: revert release workflow changes (#746)

* ci: debug

* ci: debug

* ci: revert release workflow changes

* fix: call update admin (#751)

* fix: call-update-admin

* chore: pass build

* ci: update release build tag format (#758)

ci: trigger release action on any tag format and enable release

* fix: merge release (#759)

* ci: remove cw_common from inside the docker container (#712)

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* feat: cw-mock-ibc-connection added (#711)

* feat/cw-mock-ibc-connection added

* feat: mock xcall connection added

* fix: cargo lints fixes

* fix: mock xcall connection functionality reduced

* fix: cargo lints fixes

* chore: exclude cosmwasm library and common file from contract deployment (#698)

* fix: fee check added in sendMessage (#684)

* fix: funds compare issue

* fix: fee check added in sendMessage

* style: caro lints fixes

* feat: unit test for funds in send message added

* chore: cargo lints fixes

* fix: funds compare issue

* fix: fee check added in sendMessage

* style: caro lints fixes

* feat: unit test for funds in send message added

* chore: cargo lints fixes

* fix: bug fixed in send message funds test

* fix: cargo lints fixes

* fix: owner check removed in addAdmin in xcall-mock-connection (#715)

* fix: admin and owner state changed to Addr, and corresponding tests fixed (#687)

* admin and owner state changed to Addr, and corresponding tests fixed

* style: caro lints fixes

* Revert "style: caro lints fixes"

This reverts commit 755c628.

* fix: cargo lints fixes

---------

Co-authored-by: ibrizsabin <101165234+ibrizsabin@users.noreply.github.com>

* fix: remove_admin and update_owner, update_admin are removed (#692)

* fix: remove_admin and update_owner is removed, and created a method for update_admin

* fix: transfer admin removed and add_admin updated

* fix: transfer admin removed and add_admin updated

* fix: add_owner_unauthorized removed

* ci: add terraform deployment script (#750)

* ci: add terraform deployment script

* ci: update instance tag value

* ci: fix goloop command not found by adding goloop bin path in sudo secure path

* ci: cleanup deployment script

* ci: restrict keystore directory

* ci: update permission

* ci: make secret files inaccessable to other users (#753)

* ci: make secret files inaccessable to other users

* ci: fix permission

* ci: fix typo (#756)

* fix: update admin tests

* chore: pass build

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: gcranju <134275268+gcranju@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: redlarva <91685111+redlarva@users.noreply.github.com>
Co-authored-by: izyak <76203436+izyak@users.noreply.github.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Debendra Oli <debendraoli@pm.me>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>
Co-authored-by: sabinchitrakar <immortal.infidel@gmail.com>
Co-authored-by: red__larva <red.x.larva@proton.me>
Co-authored-by: gcranju <134275268+gcranju@users.noreply.github.com>
redlarva added a commit that referenced this pull request Nov 2, 2023
@debendraoli @viveksharmapoudel
@redlarva @izyak @nightowl121 @DeepakBomjan
fix: e2e run (#737)
1075482 
* fix: ibc query method get consensus state by height should return any type (#727)

* patch: ibc query method get consensus state by height should return any type

* fix: add uniformity

* feat: remove xcall multi submodule (#733)

* fix: remove xcall submodule

* refactor: update test execution script

* fix: update documentation

* feat: save write ack event height (#734)

* feat: save write ack event height

* chore: style fixes

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* fix: add test case

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>

* feat: test multiple packets on same height (#736)

* add(test): multiple packets on same heigt

* rf: simplfy recursion call

* ci: remove cw_common from inside the docker container (#712)

Signed-off-by: Night Owl <nightowl121@protonmail.com>

* chore: exclude cosmwasm library and common file from contract deployment (#698)

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Debendra Oli <debendraoli@pm.me>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>

* feat: get relayer version from comment, fix: ami build

* rf: remove unnessary step

* feat: test multiple packets on same height

* fix: use constant version of cosmwasm-check@1.4.1 for build

* fix: e2e test setup

* fix: integration test

---------

Signed-off-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>
Co-authored-by: redlarva <91685111+redlarva@users.noreply.github.com>
Co-authored-by: izyak <76203436+izyak@users.noreply.github.com>
Co-authored-by: Night Owl <nightowl121@protonmail.com>
Co-authored-by: Night Owl <91905208+nightowl121@users.noreply.github.com>
Co-authored-by: DeepakBomjan <44976635+DeepakBomjan@users.noreply.github.com>
Co-authored-by: red__larva <red.x.larva@proton.me>
Co-authored-by: izyak <lbackup887@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redlarva redlarva redlarva approved these changes

@srmaharjan srmaharjan srmaharjan approved these changes

@ibrizsabin ibrizsabin Awaiting requested review from ibrizsabin

@AntonAndell AntonAndell Awaiting requested review from AntonAndell

@nightowl121 nightowl121 Awaiting requested review from nightowl121

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@izyak @srmaharjan @redlarva @viveksharmapoudel @nightowl121