Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add seperate varint decoder which handles long values #779

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Nov 6, 2023

Currently we use the size decoder to decode varints, but it is limited to ints. While varints can be as large as longs. So if to large values where supplied the decoding failed

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell added the enhancement New feature or request label Nov 6, 2023
Currently we use the size decoder to decode varints, but it is limited to ints. While varints can be as large as longs. So if to large values where supplied the decoding failed
@AntonAndell AntonAndell force-pushed the fix/overflow-when-decoding-varints-in-protobuf branch from cfd7fab to 98ba46a Compare November 6, 2023 14:57
@codecov-commenter
Copy link

Codecov Report

Merging #779 (98ba46a) into main (1075482) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #779   +/-   ##
=========================================
  Coverage     70.10%   70.10%           
  Complexity      409      409           
=========================================
  Files           154      154           
  Lines         13931    13931           
  Branches        293      293           
=========================================
  Hits           9766     9766           
  Misses         4012     4012           
  Partials        153      153           
Flag Coverage Δ
java 81.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ibrizsabin ibrizsabin merged commit c34fcc5 into main Jan 11, 2024
6 checks passed
@ibrizsabin ibrizsabin deleted the fix/overflow-when-decoding-varints-in-protobuf branch January 11, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants