Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Make DISPATCHES an optional dependency for HERON #221

Closed
10 tasks done
GabrielSoto-INL opened this issue Oct 25, 2022 · 1 comment
Closed
10 tasks done

[TASK] Make DISPATCHES an optional dependency for HERON #221

GabrielSoto-INL opened this issue Oct 25, 2022 · 1 comment
Assignees
@GabrielSoto-INL
Labels
priority-normal tasks that may be time sensitive, but are not necessarily critical task Feature requests

Comments

@GabrielSoto-INL
Copy link
Collaborator

GabrielSoto-INL commented Oct 25, 2022 •
edited by dylanjm
Loading

Issue Description

Is your feature request related to a problem? Please describe.
Since DISPATCHES is an optional workflow, the package should also be optionally installed during the HERON installation. HERON should additionally check that DISPATCHES is properly installed in the conda environment before running the DISPATCHES workflow.

Describe the solution you'd like

Describe alternatives you've considered

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@GabrielSoto-INL GabrielSoto-INL added the task Feature requests label Oct 25, 2022
@GabrielSoto-INL GabrielSoto-INL self-assigned this Oct 25, 2022
@GabrielSoto-INL GabrielSoto-INL added the priority-normal tasks that may be time sensitive, but are not necessarily critical label Oct 28, 2022
@GabrielSoto-INL GabrielSoto-INL mentioned this issue Oct 28, 2022
Merged
9 tasks
@dylanjm
Copy link
Collaborator

dylanjm commented Oct 28, 2022

Issue is approved to close via #222

@dylanjm dylanjm closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GabrielSoto-INL GabrielSoto-INL

Labels
priority-normal tasks that may be time sensitive, but are not necessarily critical task Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanjm @GabrielSoto-INL