Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Read optimization window size from input file #77

Closed
5 of 10 tasks
wanghy-anl opened this issue Apr 9, 2021 · 2 comments · Fixed by #79
Closed
5 of 10 tasks

[TASK] Read optimization window size from input file #77

wanghy-anl opened this issue Apr 9, 2021 · 2 comments · Fixed by #79
Labels
priority-minor tasks or issues that are not time-sensitive or critical task Feature requests

Comments

@wanghy-anl
Copy link
Contributor

wanghy-anl commented Apr 9, 2021


Issue Description

Is your feature request related to a problem? Please describe.
I would like to request a feature that the optimization window length can be specified in the input file. Currently the window length is fixed to 24 hours, as listed in Line 70 of the "pyomo_dispatch.py".

Describe the solution you'd like
Allow the pyomo to read the <time_discretization> section for the <num_steps> entry from the input file, and update the "self._window_len" in the "pyomo_dispatch.py" accordingly. Paul said it would be possible to expose this window size to the user, by registering it in the “get_input_specs” and reading it in the “read_input”.

Describe alternatives you've considered
N/A


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wanghy-anl wanghy-anl added the task Feature requests label Apr 9, 2021
@PaulTalbot-INL PaulTalbot-INL added the priority-minor tasks or issues that are not time-sensitive or critical label Apr 12, 2021
@PaulTalbot-INL
Copy link
Collaborator

FYI a fix for this has been posted as a pull request, so the next submodule update for RAVEN should include this feature.

@wanghy-anl
Copy link
Contributor Author

Thank you Paul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-minor tasks or issues that are not time-sensitive or critical task Feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants