Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching legends to upper right (what best used to mean) #54

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

joshua-cogliati-inl
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl commented Oct 5, 2022


Pull Request Description

What issue does this change request address?

idaholab/raven#1972

What are the significant changes in functionality due to this change request?

Matplotlib no longer allows 'best' as the legend location. This switches it to 'upper right' (which is what it meant in previous versions)
Update the xml reader to use new methods.
Sort sets before comparing them so it finds the same ones.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Regression tests have to complete successfully.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good.

@wangcj05
Copy link
Collaborator

wangcj05 commented Oct 6, 2022

checklist is good, and tests are green. PR can be merged.

@wangcj05 wangcj05 merged commit 3a73200 into idaholab:devel Oct 6, 2022
@joshua-cogliati-inl joshua-cogliati-inl deleted the fix_legend_loc branch October 6, 2022 15:18
@wangcj05
Copy link
Collaborator

wangcj05 commented Oct 6, 2022

@joshua-cogliati-inl Thanks for your contribution. I have merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants