Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileExistsError when making new folder #1070

Closed
10 tasks done
JiaZhou-PU opened this issue Oct 14, 2019 · 2 comments · Fixed by #1069
Closed
10 tasks done

FileExistsError when making new folder #1070

JiaZhou-PU opened this issue Oct 14, 2019 · 2 comments · Fixed by #1069

Comments

@JiaZhou-PU
Copy link
Collaborator

JiaZhou-PU commented Oct 14, 2019


Defect Description

Describe the defect

What did you see instead?

When using raven creating folder, there might have a FileExistsError, because the FileExistsError is a new error type in python 3.

Do you have a suggested fix for the development team?

Adding exist_ok=True to os.makedirs


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa
Copy link
Collaborator

alfoa commented Oct 14, 2019

How?

@alfoa
Copy link
Collaborator

alfoa commented Oct 18, 2019

Closure checklist passed...

Closure approved via #1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants