Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Heavy Tests for Simulated Annealing timing out #1219

Closed
10 tasks done
Jimmy-INL opened this issue Apr 20, 2020 · 1 comment · Fixed by #1220
Closed
10 tasks done

[DEFECT] Heavy Tests for Simulated Annealing timing out #1219

Jimmy-INL opened this issue Apr 20, 2020 · 1 comment · Fixed by #1220

Comments

@Jimmy-INL
Copy link
Collaborator

Jimmy-INL commented Apr 20, 2020


Defect Description

Describe the defect
for the three heavy tests for simulated annealing, the max time of 700 sec is not enough on some of the machines, and hence it is timing out.

What did you expect to see happen?

tests should pass.

What did you see instead?

heavy tests timed out.

Do you have a suggested fix for the development team?

Yes, increase the max time

Describe how to Reproduce
Steps to reproduce the behavior:
Just run the heavy tests.
Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa
Copy link
Collaborator

alfoa commented Apr 21, 2020

Closure checklist passed...

Closing is approved via PR #1220

No email is required, since this is a timeout of New Heavy tests (that never got tested in the actual heavy test machine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants