Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEFECT] Optimizer user guide inputs not tested #1311

Closed
10 tasks done
PaulTalbot-INL opened this issue Aug 21, 2020 · 1 comment · Fixed by #1312
Closed
10 tasks done

[DEFECT] Optimizer user guide inputs not tested #1311

PaulTalbot-INL opened this issue Aug 21, 2020 · 1 comment · Fixed by #1312
Assignees
@PaulTalbot-INL
Labels
defect priority_normal

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Aug 21, 2020 •
edited by alfoa
Loading

Defect Description

It appears the tests file is missing from raven/tests/framework/user_guide/optimizing, meaning those tests aren't run as part of the regression system, and have become outdated.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@PaulTalbot-INL PaulTalbot-INL self-assigned this Aug 21, 2020
@PaulTalbot-INL PaulTalbot-INL mentioned this issue Aug 21, 2020
Merged
9 tasks
@alfoa
Copy link
Collaborator

alfoa commented Aug 21, 2020

Closure approved via #1312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulTalbot-INL PaulTalbot-INL

Labels
defect priority_normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

User Guide optimization case testing PaulTalbot-INL/raven
2 participants
@PaulTalbot-INL @alfoa