Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Enabling method profiling for development work #1317

Closed
10 tasks done
PaulTalbot-INL opened this issue Sep 2, 2020 · 1 comment · Fixed by #1318
Closed
10 tasks done

[TASK] Enabling method profiling for development work #1317

PaulTalbot-INL opened this issue Sep 2, 2020 · 1 comment · Fixed by #1318
Assignees
@PaulTalbot-INL
Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Sep 2, 2020 •
edited by alfoa
Loading

Issue Description

Many developers have manually implemented some kind of profiling environment to see where slowdowns are happening in the code.

Making this generally accessible via developer mode would be useful esp. for new developers.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@PaulTalbot-INL PaulTalbot-INL added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Sep 2, 2020
@PaulTalbot-INL PaulTalbot-INL self-assigned this Sep 2, 2020
@PaulTalbot-INL PaulTalbot-INL mentioned this issue Sep 2, 2020
Merged
9 tasks
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Oct 2, 2020
@alfoa
Copy link
Collaborator

alfoa commented Oct 2, 2020

Closure checklist passed...

Issue approved to be closed via #1318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulTalbot-INL PaulTalbot-INL

Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling profiling in RAVEN PaulTalbot-INL/raven
2 participants
@PaulTalbot-INL @alfoa