Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add lagged parameter creation #1522

Closed
10 tasks done
joshua-cogliati-inl opened this issue Apr 20, 2021 · 1 comment · Fixed by #1523
Closed
10 tasks done

[TASK] Add lagged parameter creation #1522

joshua-cogliati-inl opened this issue Apr 20, 2021 · 1 comment · Fixed by #1523
Assignees
@alfoa
Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment

Comments

@joshua-cogliati-inl
Copy link
Contributor

joshua-cogliati-inl commented Apr 20, 2021 •
edited by alfoa
Loading

Issue Description

Is your feature request related to a problem? Please describe.
There is no in RAVEN way to create lagged parameters in a HistorySet

Describe the solution you'd like
It would be useful if there was a PostProcessor that could take a variable in a HistorySet, and add some lagged parameters (like the previous hour, previous day etc).

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@joshua-cogliati-inl joshua-cogliati-inl added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Apr 20, 2021
@joshua-cogliati-inl joshua-cogliati-inl mentioned this issue Apr 20, 2021
Merged
9 tasks
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Apr 28, 2021
@alfoa
Copy link
Collaborator

alfoa commented Apr 28, 2021

Checklist passed....

Closure checklist passed..

Closure approved via #1523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfoa alfoa

Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Lagged Variable PostProcessor idaholab/raven
2 participants
@joshua-cogliati-inl @alfoa