Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Time dependent data mining #1536

Closed
10 tasks done
mandd opened this issue Apr 30, 2021 · 0 comments · Fixed by #1537
Closed
10 tasks done

[DEFECT] Time dependent data mining #1536

mandd opened this issue Apr 30, 2021 · 0 comments · Fixed by #1537
Assignees
Labels
defect priority_critical RAVENv2.1 All tasks and defects that will go in RAVEN v2.1

Comments

@mandd
Copy link
Collaborator

mandd commented Apr 30, 2021


Defect Description

Describe the defect

What did you expect to see happen?

Some time dependent clustering tests have been disabled and are now failing

What did you see instead?

Tests exit with error messages
File "/Users/alfoa/projects/raven_github/raven/framework/PostProcessorFunctions/HS2PS.py", line 149, in _inverse
tempData = inputDic[hist].reshape((len(self.transformationSettings['vars']),self.transformationSettings['timeLength']))
ValueError: cannot reshape array of size 304 into shape (3,100)

Do you have a suggested fix for the development team?

Restore all time dependent clustering tests
Fix reshaping related bug

Describe how to Reproduce
Steps to reproduce the behavior:

  1. run test file such as test_TD_MeanShift.xml

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect priority_critical RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants