Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Dymola interface does not show error #1635

Closed
10 tasks done
mgarrouste opened this issue Aug 10, 2021 · 2 comments · Fixed by #1636
Closed
10 tasks done

[DEFECT] Dymola interface does not show error #1635

mgarrouste opened this issue Aug 10, 2021 · 2 comments · Fixed by #1636
Assignees
Labels
defect priority_normal RAVENv2.1 All tasks and defects that will go in RAVEN v2.1

Comments

@mgarrouste
Copy link
Contributor

mgarrouste commented Aug 10, 2021


Defect Description

I tried to run dymola from RAVEN using the Code Models

What did you expect to see happen?

An explanation about why the Dymola executable could not be launched

What did you see instead?

The job failed without any explanation. The dslog is printed in one of the subfolders but not easily accessible

Do you have a suggested fix for the development team?

Print the location or the content of the Dymola dslog in the RAVEN out file

Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS] Windows
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP] CONDA

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@PaulTalbot-INL
Copy link
Collaborator

In digging around, I found that we should be printing this statement on a failed code run generally speaking, so it might be specific to Dymola. I suspect either finalizeCodeOutput or checkForOutputFailure is to blame, but I need to confirm that still.

@PaulTalbot-INL
Copy link
Collaborator

Marisol confirmed that, when the license file is not present, the run command fails but returns code 0, so we can check for this in the checkForOutputFailure option.

@wangcj05 wangcj05 added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect priority_normal RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants