Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Two Points Crossover doesn't work #1724

Closed
13 tasks done
Jimmy-INL opened this issue Nov 29, 2021 · 1 comment · Fixed by #1723
Closed
13 tasks done

[DEFECT] Two Points Crossover doesn't work #1724

Jimmy-INL opened this issue Nov 29, 2021 · 1 comment · Fixed by #1723
Assignees
Labels

Comments

@Jimmy-INL
Copy link
Collaborator

Jimmy-INL commented Nov 29, 2021

Thank you for the defect report

Defect Description

Once I run any GA optimization with two points cross over it errors out as follows
Traceback (most recent call last): File "/Users/abdomg/projects/raven/framework/Driver.py", line 313, in <module> raven() File "/Users/abdomg/projects/raven/framework/Driver.py", line 266, in raven simulation.run() File "/Users/abdomg/projects/raven/framework/Simulation.py", line 764, in run stepInstance.takeAstep(stepInputDict) File "/Users/abdomg/projects/raven/framework/Steps/Step.py", line 326, in takeAstep self._localTakeAstepRun(inDictionary) File "/Users/abdomg/projects/raven/framework/Steps/MultiRun.py", line 227, in _localTakeAstepRun sampler.finalizeActualSampling(finishedJobList[0],model,inputs) File "/Users/abdomg/projects/raven/framework/Samplers/Sampler.py", line 1074, in finalizeActualSampling self.localFinalizeActualSampling(jobObject,model,myInput) File "/Users/abdomg/projects/raven/framework/Optimizers/RavenSampled.py", line 303, in localFinalizeActualSampling self._useRealization(info, rlz) File "/Users/abdomg/projects/raven/framework/Optimizers/GeneticAlgorithm.py", line 488, in _useRealization points = self._crossoverPoints) TypeError: twoPointsCrossover() missing 1 required positional argument: 'parentIndexes'

Steps to Reproduce

CHange any GA test to use two points cross over

Expected Behavior

No errors

Screenshots and Input Files

Screen Shot 2021-11-29 at 1 39 09 PM

OS

MacOS

OS Version

11.6.1

Dependency Manager

CONDA

For Change Control Board: Issue Review

  • Is it tagged with a type: defect or task?
  • Is it tagged with a priority: critical, normal or minor?
  • If it will impact requirements or requirements tests, is it tagged with requirements?
  • If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

  • If the issue is a defect, is the defect fixed?
  • If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wangcj05
Copy link
Collaborator

wangcj05 commented Dec 9, 2021

Defect is about crash, an email to users is optional. @Jimmy-INL @mandd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants