Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Request metrics/statistics from BasicStatistics when using EconomicRatio #1752

Closed
10 tasks done
dgarrett622 opened this issue Jan 25, 2022 · 1 comment · Fixed by #1763
Closed
10 tasks done
Assignees
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@dgarrett622
Copy link
Collaborator

dgarrett622 commented Jan 25, 2022


Issue Description

Is your feature request related to a problem? Please describe.
When requesting Value at Risk from EconomicRatio, it would be preferable to also be able to request additional metrics (including standard errors) on the NPV. The way to do this with the current implementation is to run another step with BasicStatistics.

Describe the solution you'd like
Request BasicStatistics metrics from EconomicRatio directly. This would remove the need for a second postprocessing step for workflows where value at risk and metrics on NPV are requested.

Describe alternatives you've considered
EconomicRatio already inherits from BasicStatistics. The simplest solution seems to be to modify the methods in EconomicRatio to enable the metrics from BasicStatistics to pass through to EconomicRatio. From the user perspective, nothing changes for BasicStatistics and EconomicRatio will have enhanced features.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@dgarrett622 dgarrett622 added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Jan 25, 2022
@dgarrett622 dgarrett622 self-assigned this Jan 25, 2022
@PaulTalbot-INL PaulTalbot-INL linked a pull request Feb 9, 2022 that will close this issue
9 tasks
@PaulTalbot-INL
Copy link
Collaborator

Approved to close via #1763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants