[DEFECT] LOGOS plugin failed due to recent changes in BasicStatistics PP

[wangcj05]

Thank you for the defect report

• I am using the latest version of RAVEN.
• I have read the Wiki.
• I have created a minimum, reproducible example
  that demonstrates the defect.

Defect Description

• Recent changes in Basic Statistics PostProcessor causes the failure of LOGOS plugin. This happens due to the add of pivotParameter into meta parameters when only static data is provided. In this case, the pivotParameter will be None, which should not be included in the meta params.

• Another issue was found in the Basic Statistics PP, the recent implementation of standard error for percentile calculation causes the timeout of SR2ML test. By investigating the tests, it seems the calculation of the standard error for percentile takes much longer to run, for example, the test /SR2ML/tests/CRAFT/test_sept_milestone.xml takes about 130s to complete before the changes, but it takes more than 450s to run for the current devel of raven. Suggestion: to disable the calculation unless requested

Steps to Reproduce

LOGOS plugin is currently failing due to this issue.

Expected Behavior

LOGOS test LOGOS/tests/MilestoneTestsSeptFY19/use_case_II/raven_capital_budgeting_II.xml should run

Screenshots and Input Files

No response

OS

MacOS

OS Version

No response

Dependency Manager

CONDA

For Change Control Board: Issue Review

• Is it tagged with a type: defect or task?
• Is it tagged with a priority: critical, normal or minor?
• If it will impact requirements or requirements tests, is it tagged with requirements?
• If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
• Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

• If the issue is a defect, is the defect fixed?
• If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
• If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
• If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
• If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

[wangcj05]

@PaulTalbot-INL @dgarrett622 I would like you to be aware of this issue, and let me know what do you think.

[PaulTalbot-INL]

I agree, if it's all static we probably don't want to provide the pivot Parameter.

[dgarrett622]

The same issue will probably happen in EconomicRatio for valueAtRisk and expectedShortfall. The pivot Parameter should be removed there as well.