Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKL Time-Dependent (consistent times) #554

Closed
10 tasks done
PaulTalbot-INL opened this issue Jan 29, 2018 · 1 comment · Fixed by #555
Closed
10 tasks done

SKL Time-Dependent (consistent times) #554

PaulTalbot-INL opened this issue Jan 29, 2018 · 1 comment · Fixed by #555

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Jan 29, 2018


Issue Description

What did you expect to see happen?

A model with consistent "time" output values should train a time-dependent SciKitLearn ROM as well as any other model/ROM combination.

What did you see instead?

The ROM only trained on the first realization's values, and ignored the rest.

Do you have a suggested fix for the development team?

Fix the logic in the SupervisedLearning.SciKitLearn ROM. Right now it checks if any of the variables have the same output in all realizations; if so, use all the data from only the first realization. What it should do is check if all of the variables have the same output in all realizations.

Note there is not a good regression test for time-dependent SKL ROMs right now.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users. since the fix is fast, we can email when we fix it
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed? yes
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.) yes
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)? email prepared
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)? n/a
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided? PR fixed single-value-duplication error for SKL ROMs #555
@alfoa
Copy link
Collaborator

alfoa commented Feb 1, 2018

checklist passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants