Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMA reseeding not as expected #597

Closed
10 tasks done
PaulTalbot-INL opened this issue Mar 19, 2018 · 1 comment · Fixed by #958 or #976
Closed
10 tasks done

ARMA reseeding not as expected #597

PaulTalbot-INL opened this issue Mar 19, 2018 · 1 comment · Fixed by #958 or #976
Labels
priority_critical task This tag should be used for any new capability, improvement or enanchment

Comments

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Mar 19, 2018


Issue Description

What did you expect to see happen?

Seeding of ARMA ROM should be controlled independent of other seeds (Monte Carlo samplers, etc).

What did you see instead?

RNG is global in RAVEN, so seeding is for the entire workflow, not individual parts.

Do you have a suggested fix for the development team?

Move RNG from global to local implementation, so entities needing random numbers can be distinct but reproducible.

The ARMA reseed test needs this improvement to be consistent.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@PaulTalbot-INL PaulTalbot-INL added priority_critical task This tag should be used for any new capability, improvement or enanchment labels Mar 19, 2018
@PaulTalbot-INL PaulTalbot-INL mentioned this issue Mar 19, 2018
8 tasks
@PaulTalbot-INL PaulTalbot-INL mentioned this issue Jun 7, 2018
8 tasks
@PaulTalbot-INL
Copy link
Collaborator Author

Approved to close via #958.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_critical task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
1 participant