RELAP5 code interface

[AaronEpiney]

---

Issue Description

The RELAP5 code interface tries to sort dictionaries (RELAPparser.py line 146). This leads to a crush.

---

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

• 1. Is it tagged with a type: defect or task?
• 2. Is it tagged with a priority: critical, normal or minor?
• 3. If it will impact requirements or requirements tests, is it tagged with requirements?
• 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users. Crash, no wrong results
• 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

---

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

• 1. If the issue is a defect, is the defect fixed?
• 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
• 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
• 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
• 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

[wangcj05]

Several things need to be checked before the closure of this issue:

1. Do we test the interface with the crashing?
2. An email should send out to the users
3. I think this issue will also affect the latest release.

@PaulTalbot-INL @alfoa Please let me know what do you think?

[alfoa]

Regarding the email to the users, It is not needed since no wrong results are caused by the issue but a crash of the external code interface.
Regarding the other 2 questions, I agree. A test should be added and I am tagging this issue with the tag for the next release.

[alfoa]

Ref. #988

[wangcj05]

Currently, the fix in PR #1066 will fix the defect, but there is no good way to test this defect. Test could be added latter when we found a way to test it. In addition, I think this defect is affecting current release. A bug fix/issue should be created for the current release. This is assigned to @alfoa.
Overall, the checklists are good, and can be closed with PR #1066